feat: expose preventDefault in react hook (#48) #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So as not to break the API I opted to make preventDefault an optional parameter on the useKey and useKeyCombo hooks (React) / composables (Vue) test: added tests for the preventDefault option in useKey/useKeyCombo for React and Vue fix: useKeyCombo Vue composable was not unbinding key combos correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So as not to break the API I opted to make preventDefault an optional parameter on the useKey and useKeyCombo hooks (React) / composables (Vue)
test: added tests for the preventDefault option in useKey/useKeyCombo for React and Vue
fix: useKeyCombo Vue composable was not unbinding key combos correctly
Vue Language Server was being painfully picky about the typings in useKeyCombo so I had to extract the generic type from the keystrokes instance... someone who knows more Typescript than me likely has a nicer way to handle this.