-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Made UserClickable opening userInfo #700
fix: Made UserClickable opening userInfo #700
Conversation
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @thepiyush-303
It is taking time to open sidebar, instead, open the user panel and inside that, show a throbber and load member details along with appropriate error if it fails
Take inspiration from how on userclick or avatar click, it shows userinfo
Done. |
Hey @thepiyush-303 |
Let me repeat my feedback.. On userclick (except here and all), open the sidebar first, show throbber, go ahead and make a request.. if success display user detail, otherwise display failed to fetch user info with the same design we have implemented in other sidepanels |
Are you talking about |
I think you're making user detail request, before opening the sidepanel.. first open it.. then make a request.. It is taking time to open sidepanel after click.. n if request is failing, the sidepanel isn't opening |
I got you I will fix it. |
@Spiral-Memory |
I am facing two issues with this implementation. Could you please help address them?
I am attaching a video and a photo for your reference. 2025-01-01.18-27-14.mp4 |
@Spiral-Memory Both issues are fixed. Screencast.from.2025-01-02.02-38-18.webm |
Removed showing actual error. |
@Spiral-Memory |
2ef2985
to
8f3bb40
Compare
@Spiral-Memory |
I did some unwanted changes and want to get rid of them but i lost this branch due to fresh clone closing it and will raise a new PR for it or add in one of my existing PRs. |
Brief Title
Acceptance Criteria fulfillment
Fixes # (issue)
#699
Screencast.from.2024-12-19.14-04-17.webm
Video/Screenshots
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-700 after approval. Contributors are requested to replace
<pr_number>
with the actual PR number.