Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add keyboard shortcut key for moving starting and ending of the message #807

Merged
merged 3 commits into from
Feb 9, 2025

Conversation

thepiyush-303
Copy link
Contributor

@thepiyush-303 thepiyush-303 commented Jan 5, 2025

Brief Title

Acceptance Criteria fulfillment

  • add shortcut for arrowUp and arrowDown
  • add shortcut for arrowRight and arrowLeft

Fixes #806

Video/Screenshots

Screencast.from.2025-01-05.22-28-38.webm

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-807 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@thepiyush-303
Copy link
Contributor Author

Hello @Spiral-Memory
If in case we are adding it, would it be relevant to add a sidebar for 'keyboard shortcuts' displaying all keyboard shortcuts available in the application just like RC.

Copy link
Collaborator

@Spiral-Memory Spiral-Memory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spiral-Memory
Copy link
Collaborator

Hello @Spiral-Memory If in case we are adding it, would it be relevant to add a sidebar for 'keyboard shortcuts' displaying all keyboard shortcuts available in the application just like RC.

Not needed @thepiyush-303 for keyboard shortcut sidebar for now

@Spiral-Memory Spiral-Memory added the chore a subtle fix label Feb 9, 2025
@Spiral-Memory Spiral-Memory merged commit 26232ab into RocketChat:develop Feb 9, 2025
4 checks passed
github-actions bot added a commit that referenced this pull request Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a subtle fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a shortcut to Move beginning and ending of the message
2 participants