Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/fix: upgrade actions/upload-artifact to v4 to address deprecation #917

Merged
merged 2 commits into from
Feb 2, 2025

Conversation

SinghaAnirban005
Copy link
Contributor

@SinghaAnirban005 SinghaAnirban005 commented Jan 16, 2025

Brief Title

Upgrade actions/upload-artifact to v4 to address deprecation

Acceptance Criteria fulfillment

  • Upgraded actions/upload-artifact to v4
  • Updated actions/checkout from v3 to v4
  • Updated actions/setup-node from v3 to v4
  • Fixed the deprecated set-output command to use the newer >>$GITHUB_OUTPUT syntax

Fixes #916

Video/Screenshots

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-917 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory
Copy link
Collaborator

Hi @SinghaAnirban005
I can't really see where it is failing.. but yeah, will be good to upgrade to latest version.
I will need to verify this change to ensure nothing breaks in CI/CD

@devanshkansagra Please look into this once, this change won't break anything right ?

@Spiral-Memory Spiral-Memory added the discussion Requires team discussion before proceeding. label Jan 27, 2025
@SinghaAnirban005
Copy link
Contributor Author

@Spiral-Memory sure !

@devanshkansagra
Copy link
Contributor

Hey @Spiral-Memory, I am also bit confused and this looks bit strange as prs raised before this and after this issue/pr haven't faced any crash or breakdowns in workflows, so why in case of @SinghaAnirban005 have crashed? But if this can be the case then might be we would have to upgrade the versions of workflows just to be the safe side.

@Spiral-Memory
Copy link
Collaborator

It might be due to the team working on the changes and it crashed

Anyway, we'll upgrade, just you and @SinghaAnirban005 setup a meet or something and test it from a forked / duplicate repo and if things works to be fine.. we are good to merge this

@devanshkansagra
Copy link
Contributor

@SinghaAnirban005, can you create a duplicate(but private) repo of this, and give me collabrator access to that? we will test and see the things there rather than doing it here to not cause any such issues in develop so.

@Spiral-Memory
Copy link
Collaborator

Hi,
I think this needs to be tested and merged early as possible, I am noticing playwright fails due to deprecated version in many tests

@devanshkansagra
@SinghaAnirban005

@devanshkansagra
Copy link
Contributor

Hey @Spiral-Memory, I will work on an test it with @SinghaAnirban005 tomorrow. as this is just deprecated versioning of github workflow issue so..

@Spiral-Memory
Copy link
Collaborator

Yeah yeah.. take your time

@SinghaAnirban005
Copy link
Contributor Author

@Spiral-Memory , i have tested this workflow with @devanshkansagra and are good to go with the changes

@Spiral-Memory Spiral-Memory merged commit 51597ed into RocketChat:develop Feb 2, 2025
3 checks passed
@Spiral-Memory Spiral-Memory added enhancement New feature or request chore a subtle fix and removed discussion Requires team discussion before proceeding. labels Feb 2, 2025
@Spiral-Memory Spiral-Memory changed the title fix: upgrade actions/upload-artifact to v4 to address deprecation chore/fix: upgrade actions/upload-artifact to v4 to address deprecation Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a subtle fix enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GitHub Actions: Migrate upload-artifact from v3 to v4 to resolve deprecation error
3 participants