-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore/fix: upgrade actions/upload-artifact to v4 to address deprecation #917
Conversation
2ef2985
to
8f3bb40
Compare
Hi @SinghaAnirban005 @devanshkansagra Please look into this once, this change won't break anything right ? |
@Spiral-Memory sure ! |
Hey @Spiral-Memory, I am also bit confused and this looks bit strange as prs raised before this and after this issue/pr haven't faced any crash or breakdowns in workflows, so why in case of @SinghaAnirban005 have crashed? But if this can be the case then might be we would have to upgrade the versions of workflows just to be the safe side. |
It might be due to the team working on the changes and it crashed Anyway, we'll upgrade, just you and @SinghaAnirban005 setup a meet or something and test it from a forked / duplicate repo and if things works to be fine.. we are good to merge this |
@SinghaAnirban005, can you create a duplicate(but private) repo of this, and give me collabrator access to that? we will test and see the things there rather than doing it here to not cause any such issues in develop so. |
Hi, |
Hey @Spiral-Memory, I will work on an test it with @SinghaAnirban005 tomorrow. as this is just deprecated versioning of github workflow issue so.. |
Yeah yeah.. take your time |
@Spiral-Memory , i have tested this workflow with @devanshkansagra and are good to go with the changes |
Brief Title
Upgrade actions/upload-artifact to v4 to address deprecation
Acceptance Criteria fulfillment
actions/upload-artifact
to v4actions/checkout
from v3 to v4actions/setup-node
from v3 to v4set-output
command to use the newer >>$GITHUB_OUTPUT syntaxFixes #916
Video/Screenshots
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-917 after approval. Contributors are requested to replace
<pr_number>
with the actual PR number.