-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore: Update WatermelonDB to 0.28.1-0 #6718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughUpdates the package.json dependency for @nozbe/watermelondb from ^0.28.0 to ^0.28.1-0. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it's not officially released, WatermelonDB's author mentioned it's safe Nozbe/WatermelonDB#1923 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
📒 Files selected for processing (1)
package.json
(1 hunks)
"@hookform/resolvers": "^2.9.10", | ||
"@notifee/react-native": "7.8.2", | ||
"@nozbe/watermelondb": "^0.28.0", | ||
"@nozbe/watermelondb": "^0.28.1-0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the lockfile to make this bump real.
With Yarn 1, changing package.json
alone won’t alter the installed version; yarn.lock
still pins @nozbe/watermelondb
to the previous release. Please run yarn install
(or yarn upgrade @nozbe/watermelondb@^0.28.1-0
) and commit the updated lockfile so CI and other devs actually receive the new build.
🤖 Prompt for AI Agents
In package.json around line 39, you bumped "@nozbe/watermelondb" but did not
update the lockfile; with Yarn v1 the installed version is still pinned in
yarn.lock. Run yarn install (or yarn upgrade @nozbe/watermelondb@^0.28.1-0) to
regenerate yarn.lock, verify the new version is reflected, and commit the
updated yarn.lock alongside this package.json change so CI and other developers
receive the upgraded dependency.
Proposed changes
Issue(s)
https://rocketchat.atlassian.net/browse/COMM-40
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
Summary by CodeRabbit