Skip to content

Conversation

Rohit3523
Copy link
Collaborator

@Rohit3523 Rohit3523 commented Oct 17, 2025

Proposed changes

This PR improve the private message behaviour

  1. Will not show action sheet when long hold
  2. Show a text message below the message content that says ‘Only you can see this message.’
  3. Added option to dismiss the message manually
  4. Message will automatically delete once user navigate back from room view to roomlist view

Pending thing:

  1. Align the footer
  2. Make a separate component for that info text
  3. Added pt-BR translation
  4. Add e2e test to make sure it's working 💀

Issue(s)

How to test or reproduce

Screenshots

Screenshot 2025-10-17 at 9 44 19 PM

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Copy link
Contributor

coderabbitai bot commented Oct 17, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch app-private-message

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Rohit3523 Rohit3523 requested a deployment to approve_e2e_testing October 17, 2025 16:16 — with GitHub Actions Waiting
comment,
pinned
pinned,
private: isPrivate
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't use private as variable name in class...

Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement.
I'd like to have e2e tests for the review.
I think sending an unsupported app message (/unsupported) makes you receive a private message like that, so we don't have to configure an app on mobile ws specifically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants