Skip to content

feat: add skeleton loading and error handling to ServerAvatar #6798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepak0x wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: add skeleton loading and error handling to ServerAvatar #6798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 102 additions & 4 deletions app/views/WorkspaceView/ServerAvatar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import React from 'react';
import React, { useState } from 'react';
import { StyleSheet, View } from 'react-native';
import { Image } from 'expo-image';
import SkeletonPlaceholder from 'react-native-skeleton-placeholder';

import { isTablet } from '../../lib/methods/helpers';
import { useTheme } from '../../theme';
import { CustomIcon } from '../../containers/CustomIcon';

const SIZE = 96;
const MARGIN_TOP = isTablet ? 0 : 64;
Expand All @@ -21,6 +23,27 @@ const styles = StyleSheet.create({
width: SIZE,
height: SIZE,
borderRadius: BORDER_RADIUS
},
imageContainer: {
width: SIZE,
height: SIZE,
position: 'relative'
},
skeletonOverlay: {
position: 'absolute',
top: 0,
left: 0,
right: 0,
bottom: 0,
justifyContent: 'center',
alignItems: 'center'
},
fallbackContainer: {
width: SIZE,
height: SIZE,
borderRadius: BORDER_RADIUS,
justifyContent: 'center',
alignItems: 'center'
}
});

Expand All @@ -29,13 +52,88 @@ interface IServerAvatar {
image: string;
}

// TODO: missing skeleton
const ServerAvatar = React.memo(({ url, image }: IServerAvatar) => {
const { colors } = useTheme();
const { colors, theme } = useTheme();
const isDarkMode = theme === 'dark' || theme === 'black';

const imageUri = image ? `${url}/${image}` : null;

// Track loading and error states
const [loading, setLoading] = useState(() => !!imageUri);
const [error, setError] = useState(false);

// Reset states when image changes
React.useEffect(() => {
if (imageUri) {
setLoading(true);
setError(false);
} else {
setLoading(false);
setError(false);
}
}, [imageUri]);

const handleLoadStart = () => {
setLoading(true);
setError(false);
};

const handleLoad = () => {
setLoading(false);
setError(false);
};

const handleError = () => {
setLoading(false);
setError(true);
};

// Show fallback icon on error or when no image is provided
if (error || !imageUri) {
return (
<View style={styles.container}>
<View
style={[
styles.fallbackContainer,
{
backgroundColor: isDarkMode ? colors.surfaceNeutral : 'transparent',
borderColor: colors.strokeLight,
borderWidth: 1
}
]}>
<CustomIcon name='workspaces' size={SIZE * 0.5} color={colors.fontSecondaryInfo} />
</View>
</View>
);
}

// Show the actual image with an overlaid skeleton while loading
return (
<View style={styles.container}>
{image && <Image style={[styles.image, { borderColor: colors.strokeLight }]} source={{ uri: `${url}/${image}` }} />}
<View style={styles.imageContainer}>
<Image
style={[
styles.image,
{
borderColor: colors.strokeLight,
borderWidth: 1,
backgroundColor: isDarkMode ? colors.surfaceNeutral : 'transparent'
}
]}
source={{ uri: imageUri }}
onLoadStart={handleLoadStart}
onLoad={handleLoad}
onError={handleError}
contentFit='cover'
/>
{loading && (
<View style={styles.skeletonOverlay}>
<SkeletonPlaceholder borderRadius={BORDER_RADIUS} backgroundColor={colors.surfaceNeutral}>
<SkeletonPlaceholder.Item width={SIZE} height={SIZE} borderRadius={BORDER_RADIUS} />
</SkeletonPlaceholder>
</View>
)}
</View>
</View>
);
});
Expand Down