Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: adds ruff, removes black, isort and flake8 #763

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

Gui-FernandesBR
Copy link
Member

Ruff is significantly faster than other linters. I recommend using this in your vscode.

We should start migrating from pylint to ruff little by little.

Black, isort and flake8 could already be removed from our project whenever we prefer. ruff format should replace them.

This PR only sets up the ruff check command.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 86.30137% with 10 lines in your changes missing coverage. Please review.

Project coverage is 80.07%. Comparing base (83aa20e) to head (6b06a86).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
rocketpy/environment/environment_analysis.py 0.00% 3 Missing ⚠️
rocketpy/prints/aero_surface_prints.py 33.33% 2 Missing ⚠️
rocketpy/stochastic/stochastic_flight.py 0.00% 2 Missing ⚠️
rocketpy/stochastic/stochastic_model.py 77.77% 2 Missing ⚠️
rocketpy/plots/motor_plots.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #763      +/-   ##
===========================================
+ Coverage    76.42%   80.07%   +3.65%     
===========================================
  Files           95       95              
  Lines        11090    11347     +257     
===========================================
+ Hits          8475     9086     +611     
+ Misses        2615     2261     -354     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

IMPORTANT -> the ruff formatter is still not working properly
@Gui-FernandesBR Gui-FernandesBR changed the title DEV: adds ruff linter DEV: adds ruff, removes black, isort and flake8 Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Mid-Term
Development

Successfully merging this pull request may close these issues.

1 participant