-
-
Notifications
You must be signed in to change notification settings - Fork 25
TelegramBots platform #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BlackBaroness
wants to merge
8
commits into
Rollczi:master
Choose a base branch
from
BlackBaroness:feat/telegrambots
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build is successful btw, tests failed because of ProtocolLib what is unrelated |
Jakubk15
reviewed
Feb 26, 2025
...ommands-telegrambots/src/dev/rollczi/litecommands/telegrambots/LiteTelegramBotsSettings.java
Outdated
Show resolved
Hide resolved
…mbots/LiteTelegramBotsSettings.java Co-authored-by: Jakub Kędziora <[email protected]>
I need some thoughts and help about the "problems I see" section since I cannot solve it by myself |
# Conflicts: # buildSrc/src/main/kotlin/Versions.kt
Hi @BlackBaroness Thanks for you Pull request. What do you think about these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I implemented a basic support for TelegramBots (Telegram-recommended Java library). It's kinda finished in the current state, but, due to how different it is from more common platforms like Bukkit, there are some pitfalls.
Firstly, we have some limitations here:
BiPredicate
in the settings of that platform, so the library user can implement it manually (it's a common thing for Telegram to have admin commands I believe).My suggested setup:
Problems I see:
false
currently.Update
,Message
objects to the command handles and result handlers somehow. Otherwise the library user might not be able to send messages etc.