125 opencast downloads are broken since the json returned by the api has changed #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes json parsing, but does not handle multiple possible videos
Collaborator
Author
|
I'm now done with the PR, please check/test the changes and then squash and merge |
Collaborator
Author
|
@septatrix @Romern Unless there is an objection I'd like to merge ASAP as it's affecting one of the core functions |
Collaborator
|
Still pending publication on PyPI as I am currently not at my main machine (we should probably create a CI workflow for that) |
Collaborator
Author
Yeah we should :D |
D-VR
deleted the
125-opencast-downloads-are-broken-since-the-json-returned-by-the-api-has-changed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this closes #125 with a hotfix