-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: match timeout behaviour with docs #7707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I've reviewed the changes and found some issues that need attention before this can be merged.
Important: The test file You may also want to add tests to verify that providers correctly transform 0 to 2147483647 for better test coverage of this new behavior. |
on second thought, there's no reason not to do that, brb will update it |
Related GitHub Issue
Closes: #7366
Roo Code Task Context (Optional)
Description
This PR fixes timeout to match the docs. This PR makes it so that 0 actually disables the timeout by setting it to max 32 int value (2^31 - 1).
I wonder if I should change thegetApiRequestTimeout
instead to return that value? I keep all of it at the providers right now. Tell me if that is more preferable than the current implementation.Test Procedure
Pre-Submission Checklist
Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
@elianiva
Important
Standardize timeout behavior across providers by setting it to
2147483647
whengetApiRequestTimeout()
returns 0, effectively disabling the timeout.2147483647
(2^31 - 1) whengetApiRequestTimeout()
returns 0, effectively disabling the timeout.AnthropicHandler
,BaseOpenAiCompatibleProvider
, andAwsBedrockHandler
constructors, among others.getApiRequestTimeout()
used to fetch timeout value inanthropic.ts
,base-openai-compatible-provider.ts
, andbedrock.ts
.2147483647
as the maximum timeout value.This description was created by
for 147ec36. You can customize this summary. It will automatically update as commits are pushed.