-
Notifications
You must be signed in to change notification settings - Fork 2.2k
removing user hint when refreshing models #7710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
removing user hint when refreshing models #7710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this clean and focused PR! The removal of the unnecessary hint message improves the user experience by eliminating confusion. The refresh button now works directly without requiring users to navigate away and back.
The code changes are minimal and well-executed - removing the state management complexity while maintaining functionality.
@@ -131,18 +129,12 @@ export const Requesty = ({ | |||
onClick={() => { | |||
vscode.postMessage({ type: "flushRouterModels", text: "requesty" }) | |||
refetchRouterModels() | |||
setDidRefetch(true) | |||
}}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup! Removing this state variable simplifies the component.
One minor suggestion for completeness: The translation key is now unused across the codebase. While not critical, it would be good housekeeping to remove this unused translation from all locale files (en, fr, de, etc.) to keep them clean. You could do this in a follow-up PR if you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove it?
Nice addition with the animated refresh button! Just a heads up - there's a potential memory leak with the timeout in AnimatedRefreshButton. The timeout should be cleared when the component unmounts to prevent issues if the user navigates away while the animation is active. A simple useEffect cleanup function would handle this. Let me know if you have any questions! |
Description
Previously we showed a hint to the user to go back to the home screen (which would trigger a refetch of /models in a previous Roo version). But now the button alone works, so no need for this warning
Test Procedure
Pre-Submission Checklist
Screenshots / Videos
Previously
Now
Screen.Recording.2025-09-05.at.17.13.40.mov