Skip to content

Conversation

requesty-JohnCosta27
Copy link

@requesty-JohnCosta27 requesty-JohnCosta27 commented Sep 5, 2025

Description

Previously we showed a hint to the user to go back to the home screen (which would trigger a refetch of /models in a previous Roo version). But now the button alone works, so no need for this warning

Test Procedure

  1. Select Requesty as a provider
  2. Check models list
  3. Create a new policy on the Requesty UI
  4. Click the models refresh button in Roo
  5. Check that the new policy appears.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Previously

Screenshot 2025-09-05 at 17 04 31

Now

Screen.Recording.2025-09-05.at.17.13.40.mov

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. UI/UX UI/UX related or focused size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Sep 5, 2025
Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this clean and focused PR! The removal of the unnecessary hint message improves the user experience by eliminating confusion. The refresh button now works directly without requiring users to navigate away and back.

The code changes are minimal and well-executed - removing the state management complexity while maintaining functionality.

@@ -131,18 +129,12 @@ export const Requesty = ({
onClick={() => {
vscode.postMessage({ type: "flushRouterModels", text: "requesty" })
refetchRouterModels()
setDidRefetch(true)
}}>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Removing this state variable simplifies the component.

One minor suggestion for completeness: The translation key is now unused across the codebase. While not critical, it would be good housekeeping to remove this unused translation from all locale files (en, fr, de, etc.) to keep them clean. You could do this in a follow-up PR if you prefer.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove it?

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 5, 2025
@daniel-lxs
Copy link
Collaborator

daniel-lxs commented Sep 5, 2025

Nice addition with the animated refresh button! Just a heads up - there's a potential memory leak with the timeout in AnimatedRefreshButton. The timeout should be cleared when the component unmounts to prevent issues if the user navigates away while the animation is active. A simple useEffect cleanup function would handle this.

Let me know if you have any questions!

@daniel-lxs daniel-lxs moved this from Triage to PR [Changes Requested] in Roo Code Roadmap Sep 5, 2025
@hannesrudolph hannesrudolph added PR - Changes Requested and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR - Changes Requested size:M This PR changes 30-99 lines, ignoring generated files. UI/UX UI/UX related or focused
Projects
Status: PR [Changes Requested]
Development

Successfully merging this pull request may close these issues.

3 participants