Skip to content

Add socket connection abstraction - #77

Closed
Roy2player wants to merge 8 commits into
masterfrom
tls-protocol-implementation
Closed

Add socket connection abstraction#77
Roy2player wants to merge 8 commits into
masterfrom
tls-protocol-implementation

Conversation

@Roy2player

@Roy2player Roy2player commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

According to preparation to implement TLS 1.3 #71

@Roy2player Roy2player self-assigned this Jun 4, 2026
Copilot AI review requested due to automatic review settings June 4, 2026 21:25
@Roy2player Roy2player added feature New feature or request library Related to MSAPI library labels Jun 4, 2026
Copilot AI reviewed Jun 4, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new server-side socket connection abstraction (MSAPI::Connection) as groundwork for upcoming TLS 1.3 support (#71), aiming to centralize connection I/O (recv/send/splice/close) and allow pluggable recv/send behavior.

Changes:

  • Introduces MSAPI::Connection wrapper with per-connection id, send/recv locks, and overridable recv/send functions.
  • Adds convenience APIs for Recv(), Send(), Splice(), and Close() with logging and basic error handling.
  • Adds placeholders (@todo) indicating intent to add unit tests for the new abstraction.

Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl Outdated
Comment thread library/source/server/connection.inl Outdated
Comment thread library/source/server/connection.inl Outdated
Comment thread library/source/server/connection.inl Outdated
Comment thread library/source/server/connection.inl Outdated
Comment thread library/source/server/connection.inl Outdated
Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl
@Roy2player Roy2player moved this to In Progress in MSAPI supporting Jun 4, 2026
@Roy2player
Roy2player requested a review from Copilot June 4, 2026 21:56
@Roy2player Roy2player linked an issue Jun 4, 2026 that may be closed by this pull request
Implement TLS 1.3 #71
Open
2 tasks
Copilot AI reviewed Jun 4, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 10 comments.

Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl Outdated
Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl
@Roy2player
Roy2player requested a review from Copilot June 5, 2026 20:25
Copilot AI reviewed Jun 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 14 comments.

Comment thread library/source/server/connection.inl Outdated
Comment thread library/source/server/connection.inl Outdated
Comment thread library/source/server/connection.inl Outdated
Comment thread library/source/server/connection.inl Outdated
Comment thread library/source/server/connection.inl Outdated
Comment thread library/source/server/connection.inl Outdated
Comment thread library/source/server/connection.inl Outdated
Comment thread library/source/server/connection.inl Outdated
Comment thread library/source/server/connection.inl Outdated
Comment thread library/source/server/connection.inl
@Roy2player
Roy2player requested a review from Copilot June 5, 2026 20:50
Copilot AI reviewed Jun 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

Comment thread library/source/server/connection.inl Outdated
Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl
@Roy2player
Roy2player requested a review from Copilot June 5, 2026 20:58
Copilot AI reviewed Jun 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl Outdated
Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl Outdated
@Roy2player
Roy2player requested a review from Copilot June 5, 2026 21:06
Copilot AI reviewed Jun 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.

Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl
@Roy2player
Roy2player requested a review from Copilot June 5, 2026 21:26
Copilot AI reviewed Jun 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl Outdated
@Roy2player
Roy2player requested a review from Copilot June 5, 2026 21:39
Copilot AI reviewed Jun 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.

Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl
Comment thread library/source/server/connection.inl
@Roy2player
Roy2player marked this pull request as draft August 24, 2026 17:59
@Roy2player Roy2player closed this Aug 24, 2026
@Roy2player
Roy2player deleted the tls-protocol-implementation branch August 24, 2026 17:59
@github-project-automation github-project-automation Bot moved this from In Progress to Done in MSAPI supporting Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

@Roy2player Roy2player

Labels

feature New feature or request library Related to MSAPI library

Projects

MSAPI supporting
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement TLS 1.3

2 participants

@Roy2player