Skip to content

Episode 1: Blackjack Pull Request #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Episode 1: Blackjack Pull Request #16

wants to merge 1 commit into from

Conversation

moserrya
Copy link

Completed the Panda and Tiger levels and looking forward to your feedback!

@moserrya moserrya closed this Nov 20, 2012
@moserrya moserrya reopened this Nov 20, 2012
@@ -225,6 +237,13 @@ def inspect
game.status[:winner].should_not be_nil
end

it "should stand automatically when the player busts" do
game = Game.new
game.hit while game.status[:player_value] < 22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of the inline while here! Reads very nicely.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think if the player's value was 21, that case would be handled appropriately? Or would it try to hit?

@jwo
Copy link
Member

jwo commented Nov 23, 2012

Looks great; I added a couple of comments. Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants