-
Notifications
You must be signed in to change notification settings - Fork 22
Episode6 - Assignments #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mee213
wants to merge
7
commits into
RubyoffRails:master
Choose a base branch
from
mee213:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c104ea0
Panda Assignment - automobile.rb
mee213 41b5aed
Tiger assignment - automobile.rb, vehicle.rb, motorcycle.rb
mee213 c0105c9
Eagle Assignment - first attempt at #1 & #2
mee213 8e9eb19
Eagle Assignment - second attempt at #2
mee213 39e38bc
Eagle Assignment - second attempt at #1
mee213 b78286d
Eagle Assignment - third attempt at #1
mee213 cadf9ad
Eagle Assignment - third attempt for #1
mee213 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
class Automobile < Vehicle | ||
|
||
attr_accessor :color, :make, :model, :year | ||
|
||
def initialize(color, make, model, year) | ||
@color = color | ||
@make = make | ||
@model = model | ||
@year = year | ||
end | ||
|
||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
class Motorcycle < Vehicle | ||
def self.tires | ||
2 | ||
end | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
class Vehicle | ||
|
||
@@allvehicles = [] | ||
|
||
def initialize | ||
@@allvehicles << self | ||
end | ||
|
||
def self.tires | ||
4 | ||
end | ||
|
||
def self.filter | ||
@@allvehicles.select do |i| | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is SO CLOSE, awesome job! If you check this code out, I think you'll see that it only matches on the model of "Accord". So a Black Toyota Accord would match. But if you: i.color == "Blue" && i.make == "Honda" && i.model == "Accord" you'd have it! |
||
i.color == "Blue" && i.make == "Honda" && i.model == "Accord" | ||
end | ||
end | ||
|
||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With class variables, just doing is enough to initialize them. so your
def initialize
isn't needed