Skip to content

fix(kotlin): stop public extensions from swallowing coroutine cancellation #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanchitmonga22 merged 1 commit into from
Jul 25, 2026
Merged

fix(kotlin): stop public extensions from swallowing coroutine cancellation #572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...src/main/kotlin/com/runanywhere/sdk/public/extensions/Models/RunAnywhereModelLifecycle.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import com.runanywhere.sdk.public.RunAnywhere
import com.runanywhere.sdk.public.types.RAModelInfo
import com.runanywhere.sdk.public.types.RAModelLoadRequest
import com.runanywhere.sdk.public.types.RAModelLoadResult
import kotlinx.coroutines.CancellationException
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext

Expand All @@ -48,7 +49,9 @@ suspend fun RunAnywhere.loadModel(request: RAModelLoadRequest): RAModelLoadResul
}
try {
ensureServicesReady()
} catch (_: Throwable) {
} catch (e: CancellationException) {
throw e
} catch (_: Exception) {
}
val result =
CppBridgeModelLifecycle.load(request)
Expand Down
5 changes: 4 additions & 1 deletion ...ywhere-kotlin/src/main/kotlin/com/runanywhere/sdk/public/extensions/STT/RunAnywhereSTT.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import com.runanywhere.sdk.infrastructure.logging.SDKLogger
import com.runanywhere.sdk.public.RunAnywhere
import com.runanywhere.sdk.public.types.RASTTOptions
import com.runanywhere.sdk.public.types.RASTTOutput
import kotlinx.coroutines.CancellationException
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.channels.awaitClose
import kotlinx.coroutines.flow.Flow
Expand Down Expand Up @@ -108,7 +109,9 @@ fun RunAnywhere.transcribeStream(
trySend(RASTTPartialResult(is_final = true))
}
close()
} catch (e: Throwable) {
} catch (e: CancellationException) {
throw e
} catch (e: Exception) {
trySend(
RASTTPartialResult(
text = "STT stream failed: ${e.message ?: e::class.simpleName.orEmpty()}",
Expand Down
2 changes: 1 addition & 1 deletion ...tlin/src/main/kotlin/com/runanywhere/sdk/public/extensions/Storage/RunAnywhereDownload.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ suspend fun RunAnywhere.downloadModel(
downloadLogger.info(
"Download cancelled for ${resolvedModel.id} (task=${startResult.task_id})",
)
} catch (e: Throwable) {
} catch (e: Exception) {
downloadLogger.warn(
"Failed to cancel native download for ${resolvedModel.id} " +
"(task=${startResult.task_id}): ${e.message}",
Expand Down
5 changes: 4 additions & 1 deletion ...ywhere-kotlin/src/main/kotlin/com/runanywhere/sdk/public/extensions/TTS/RunAnywhereTTS.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import com.runanywhere.sdk.native.bridge.RunAnywhereBridge
import com.runanywhere.sdk.public.RunAnywhere
import com.runanywhere.sdk.public.types.RATTSOptions
import com.runanywhere.sdk.public.types.RATTSOutput
import kotlinx.coroutines.CancellationException
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.NonCancellable
Expand Down Expand Up @@ -127,7 +128,9 @@ fun RunAnywhere.synthesizeStream(
trySend(output).isSuccess
}
}
} catch (t: Throwable) {
} catch (t: CancellationException) {
throw t
} catch (t: Exception) {
ttsLogger.warn("synthesizeStream errored: ${t.message}")
} finally {
close()
Expand Down
Loading