Skip to content

fix(ci): unbreak the ktlint and SwiftLint gates that are red on main #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shubhammalhotra28 merged 2 commits into from
Jul 31, 2026
Merged

fix(ci): unbreak the ktlint and SwiftLint gates that are red on main #609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
461b5b3
fix(kotlin): add blank line before KDoc in AndroidConnectTransport co…
ayaangazali Jul 31, 2026
2cebf5b
fix(ios): replace force unwrap on TaskGroup.next() in ConnectSession
ayaangazali Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...-kotlin/src/main/kotlin/com/runanywhere/sdk/foundation/connect/AndroidConnectTransport.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,7 @@ internal class AndroidConnectSocket(
const val HANDSHAKE_TIMEOUT_MS = 5_000
const val HEARTBEAT_INTERVAL_MS = 3_000L
const val HEARTBEAT_TIMEOUT_MS = 2_000

/** Generous inter-frame timeout so a stalled host is visible without false positives. */
val GENERATION_READ_TIMEOUT_MS = RADefaults.Connect.GENERATION_READ_TIMEOUT_MS
}
Expand Down
6 changes: 5 additions & 1 deletion sdk/runanywhere-swift/Sources/RunAnywhere/Public/Connect/ConnectSession.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,11 @@ public final class ConnectSession: ObservableObject {
"Timed out connecting to \(hostDisplayName)."
)
}
let value = try await group.next()!
guard let value = try await group.next() else {
throw ConnectTransportError.network(
"Connecting to \(hostDisplayName) finished without a response."
)
}
group.cancelAll()
return value
}
Expand Down
Loading