Skip to content

fix for issue #23, deletes colophon adds it to front matter history of this book #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2025

Conversation

Austing767
Copy link
Contributor

@Austing767 Austing767 commented Jul 28, 2025

Changes

Per request, I moved the wording from the colophon to the front matter of the book. Updated some of the verbiage to better match the updated context.

Related issues

Fix for #23 relates to #24 potential merge conflict.

Testing

Ran and built locally, approved by @coco3427
Needing approval from @pearcej

@Austing767 Austing767 changed the title partial fix issue #23, deletes colophon adds it to front matter history of this book fix for issue #23, deletes colophon adds it to front matter history of this book Jul 28, 2025
Copy link
Collaborator

@pearcej pearcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a much better placement since a colophone of a book is typically used to discuss the publisher, not the history. See https://en.wikipedia.org/wiki/Colophon_(publishing). So, this seems better.

One issue I see with it currently is that both links are failing. Please correct the link for pandoc to where it lives now, namely https://pandoc.org/. I don't see the original md file for the original in this repository. I would recommend either removing the sentence completely or saying "the original markdown for this file used to reside at..." since it might be in the Wayback Machine I suppose. @bnmnetp might have more to say about this.

@bnmnetp
Copy link
Member

bnmnetp commented Jul 29, 2025

I don't think anyone cares about my personal journey from RST to markdown to RST to ... Fine to delete it.

@bnmnetp
Copy link
Member

bnmnetp commented Jul 29, 2025

It kind of feels odd to have it written in the first person given that the book now has many authors.

@pearcej
Copy link
Collaborator

pearcej commented Jul 29, 2025

@Austing767 don't worry about fixing this. There are a few other changes that I plan to make. @bnmnetp I will fix the first person and discuss the original restructured text, etc.

@pearcej
Copy link
Collaborator

pearcej commented Jul 29, 2025

I don't think anyone cares about my personal journey from RST to markdown to RST to ... Fine to delete it.
I actually think it's pretty interesting!

@pearcej pearcej merged commit c61abd4 into RunestoneInteractive:master Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants