Skip to content

Conversation

Stigjb
Copy link
Contributor

@Stigjb Stigjb commented May 13, 2020

The dependencies are quite old, and I couldn't compile the crate in my project which uses a more recent version of rand.

I've made the num dependency a greater range of versions, as long as they are below v1.

I've raised the minimum version of rand to 0.5, which is when the Rand trait was deprecated, and changed the implementation of Rand for Letter to conform to the newer API.

I've successfully compiled the crate with recent versions of rand on my PR branch.

Stigjb added 2 commits May 13, 2020 13:46
num and rand dependencies were old
The Rand trait is deprecated, impl Distribution for Standard instead
Copy link
Member

@est31 est31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The >= and < dependency style is a forward compatibility hazard. Could you instead just increase the number to the latest dependency versions? Also, is really the entire num crate needed, or can one of its dependencies be used as well?

@Stigjb
Copy link
Contributor Author

Stigjb commented May 13, 2020

It turns out that everything from num used by this crate is in num-traits, so that's a few dependencies saved.

I understeed that you wanted the dependencies to be the latest versions, which will lose compatibility with older versions of rand and num - correct me if I'm wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants