cms: simplify create_signing_time
#1968
Draft
+7
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @bkstein |
baloo
force-pushed
the
baloo/cms/create_signing_time-reuse-x509-time
branch
2 times, most recently
from
48dcf81 to
e03451f
Compare
|
This should come after #1969 which makes sure the conversion from systemtime can use a utctime. |
This reuses the logic already implemented in `x509_cert::time::Time` instead of duplicating it.
baloo
force-pushed
the
baloo/cms/create_signing_time-reuse-x509-time
branch
from
e03451f to
7e1afbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reuses the logic already implemented in
x509_cert::time::Timeinstead of duplicating it.