Bump RustCrypto dependency crates to Release Candidate version #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@stevefan1999-personal can you take a look at this? I know it duplicates some of the work you were trying to do in #87, but I do like that this is just a self-contained dependency upgrade PR |
Contributor
|
@tarcieri I'm out on a trip rn and I will be back on 2nd Jan, but I will try to take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the crate to the Release Candidate version currently in development by the RustCrypto project.
ed25519_dalek::SigningKey::from_sec1_der()no longer exists, We replaced it with my own implementation. It may be better to simply not support it.rand_core::OsRnghas been moved to therandcrate. We felt that there should be no new dependency on therandcrate, and instead have a small implementation withCryptoRng + RngCoretrait functionality for compatibility.If this has already been planned by an official expert, you may close this PR.
I hope this PR will be helpful to you. :)