-
Notifications
You must be signed in to change notification settings - Fork 6
feat(react): add DropDownTree component #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -0,0 +1,12 @@ | |||
@layer component { | |||
.dropdown-tree-end { | |||
box-shadow: 2px 2px 0px 0px #000000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is not the same as shadow-rb-black
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a different class since the other one handles responsiveness. I added a new utility that already existed in another file to reuse it for this type of element.
} | ||
|
||
.rustlanges-dropdown-tree-start--extended { | ||
box-shadow: 2px 2px 0px 0px #000000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
Is not the same as shadow-rb-black?
|
||
.rustlanges-dropdown-tree-start--default { | ||
& > summary { | ||
box-shadow: 2px 2px 0px 0px #000000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
Is not the same as shadow-rb-black?
@@ -0,0 +1,33 @@ | |||
@layer component { | |||
.rustlanges-dropdown-tree-subject { | |||
box-shadow: 2px 2px 0px 0px #000000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
Is not the same as shadow-rb-black?
js/react/lib/components/dropdown-tree/dropdown-tree.subject.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Related Issue
Related to #16
Summary
Each subcomponent is focused on rendering a specific node in a hirarchical structure
Details
Multiple component to create a complete structure:
DropdownTree.Start
DropdownTree.Subject
DropdownTree.Topic
DropdownTree.SubTopic
DropdownTree.End
Type and lint safe (check:tsc & -r lint)
Screenshots
