Skip to content

fix: code quality and safety improvements #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabhhhcodes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: code quality and safety improvements #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/router/apiKeyManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ export class ApiKeyManager {
* Register an API key for a provider
*/
public registerKey(provider: string, apiKey: string): void {
if (!provider || typeof provider !== 'string' || provider.trim() === '') {
if (!provider || typeof provider !== 'string' || provider.trim().length === 0) {
throw new Error('TokenFirewall: Provider must be a non-empty string');
}
if (!apiKey || typeof apiKey !== 'string' || apiKey.trim() === '') {
if (!apiKey || typeof apiKey !== 'string' || apiKey.trim().length === 0) {
throw new Error(`TokenFirewall: Invalid API key for provider "${provider}"`);
}
this.keys.set(provider.toLowerCase(), apiKey);
Expand Down
2 changes: 1 addition & 1 deletion src/router/modelRouter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export class ModelRouter {

// Validate each fallback model name
for (const fallbackModel of fallbacks) {
if (typeof fallbackModel !== 'string' || fallbackModel.trim() === '') {
if (typeof fallbackModel !== 'string' || fallbackModel.trim().length === 0) {
throw new Error(
`TokenFirewall Router: fallbackMap for "${model}" contains invalid model name (empty or whitespace)`
);
Expand Down