Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for GRDB 7 #73

Merged
merged 3 commits into from
Mar 15, 2025
Merged

Support for GRDB 7 #73

merged 3 commits into from
Mar 15, 2025

Conversation

groue
Copy link
Collaborator

@groue groue commented Feb 5, 2025

This pull request addresses #72 by bumping the minimum GRDB version to 7.1.

@foxware00, @Lutzifer, I could merge right away, but maybe you'd prefer to giving this branch a test first.

Don't miss the Migrating From GRDB 6 to GRDB 7 guide.

groue added 2 commits January 31, 2025 17:53
There remains a warning in DatabaseRegionObservation+Rx.swift.

See #72
@Lutzifer
Copy link
Contributor

Lutzifer commented Feb 5, 2025

@groue Sorry, I'm quite busy with a project that does not use GRDB (yet), so I've not started upgrading any projects to GRDB 7 and therefore can't test.

@groue
Copy link
Collaborator Author

groue commented Feb 5, 2025

No problem, @Lutzifer! Thanks for replying. I hope the migration will be smooth when you start upgrading.

@foxware00
Copy link

Thanks @groue for the fast turn around. I'm just in the process of moving from cocoapods to spm so once that's complete i'll verify this for you and report back

@groue
Copy link
Collaborator Author

groue commented Feb 13, 2025

Thank you @foxware00. Don't rush: I'll probably merge anyway. We'll always be able to address your eventual feedback when it comes.

@tommyming
Copy link

I can also help on testing this if needed, just started migrating from cocapods to spm, and updating some packages.

@groue
Copy link
Collaborator Author

groue commented Mar 5, 2025

That would be nice @tommyming, thank you!

@tommyming
Copy link

@groue I have just add the package using DEV branch and done some basic compatibility test(e.g. database read/write using existing RxSwift Syntax), seems works fine with GRDB 7.

Please let me know if anything needs more testing, thanks!

@groue
Copy link
Collaborator Author

groue commented Mar 6, 2025

Thank you @tommyming for your help. I'll merge this PR very soon now!

@foxware00
Copy link

We're happy with this PR from our testing

@groue groue merged commit cdec912 into master Mar 15, 2025
1 check passed
@groue groue deleted the dev/GRDB7 branch March 15, 2025 10:12
@groue
Copy link
Collaborator Author

groue commented Mar 15, 2025

Thank you very much for your help! RxGRDB v4.0.0 has just shipped 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants