Skip to content

Conversation

CatoTH
Copy link

@CatoTH CatoTH commented Nov 23, 2024

Hi!
It would be great if your library would support PHP 8.4 (without deprecations). Here would be my suggestion:

  • Use \Random\Randomizer::getRandom() instead of lcg_value (if available)
  • Added nullability to parameters when appropriate
  • Removed some null values if I couldn't find a nullable use (expect for from within test cases)
  • Removed default parameters before mandatory parameters
  • One unused import (unreleated)

@S1SYPHOS
Copy link
Owner

I'll look into it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants