Enable conflict detection in sneakernet transfers#71
Enable conflict detection in sneakernet transfers#71MrKeiKun wants to merge 1 commit intoS4tvara:mainfrom
Conversation
MrKeiKun
force-pushed
the
fix-46-conflict-detection
branch
from
2935ddc to
bdbe4c4
Compare
|
Hi @MrKeiKun, Please update the conflicts, and I'll merge the PR. |
MrKeiKun
force-pushed
the
fix-46-conflict-detection
branch
from
bdbe4c4 to
2dcfe63
Compare
💡 Suggestions to Improve This PR
Consider addressing these points to make your contribution stronger. Thanks for contributing! |
MrKeiKun
force-pushed
the
fix-46-conflict-detection
branch
from
2dcfe63 to
1f7bbed
Compare
💡 Suggestions to Improve This PR
Consider addressing these points to make your contribution stronger. Thanks for contributing! |
MrKeiKun
force-pushed
the
fix-46-conflict-detection
branch
from
1f7bbed to
c1f8eea
Compare
💡 Suggestions to Improve This PR
Consider addressing these points to make your contribution stronger. Thanks for contributing! |
|
@SubstantialCattle5 rabased and updated. |
|
Cool, I'll review it later
you're getting this error because your pr doesn't follow the new template, disregard it for now. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…FileManifest Signed-off-by: Lorenzo Buitizon <[email protected]>
MrKeiKun
force-pushed
the
fix-46-conflict-detection
branch
from
c1f8eea to
e854c81
Compare
💡 Suggestions to Improve This PR
Consider addressing these points to make your contribution stronger. Thanks for contributing! |
2 participants
Description
Sneakernet conflict detection was failing because
ContentHashwas never populated inFileManifeststructures. This caused all conflict comparisons to return false, preventing detection of files with the same path but different content.Referenced Issue: #46