-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement logging in Dash-Seedling 151 #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small "nit picking" comment, but otherwise LGTM.
Do you need to add the APPLICATIONINSIGHTS_CONNECTION_STRING
into the deployment in a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think APPLICATIONINSIGHTS_CONNECTION_STRING
should be set for local, but apart from that – LGTM!
I would have
if os.environ.get("ENVIRONMENT", default="dev") == "local":
return
in initialise_logging
Co-authored-by: Tom Young <[email protected]>
APPLICATIONINSIGHTS_CONNECTION_STRING |
Resolves #151
Test Passed :