ABM3 Intra-Household AV Allocation and Taxi/TNC Routing Models #366
Conversation
…nto ABM3_AV_TNC_routing
…ching repositioning
| return skims, interaction_df | ||
|
|
||
|
|
||
| def construct_av_to_trip_alternatives(num_avs, num_trips): |
There was a problem hiding this comment.
For large households/trips, this could be slow. Shall we consider limiting alternatives if performance is an issue?
| return choices | ||
|
|
||
|
|
||
| def get_next_household_trips_to_service( |
There was a problem hiding this comment.
Is it possible making hardcoded values (e.g., number of next trips to service) configurable via settings?
JiaXu1024
left a comment
JiaXu1024
left a comment
There was a problem hiding this comment.
The AV allocation model is not directly integrated with the main ActivitySim model pipeline. Could you update the config file to include it in the workflow?
|
|
||
| class TaxiTNCSettings(BaseModel): | ||
| """ | ||
| Taxi / TNC route choice settings |
There was a problem hiding this comment.
Lines 14–66 appear to duplicate the settings in taxi_tnc_routing_settings.yaml. Could you remove the redundant entries? I also noticed that single_tnc_modes doesn’t match the value in the YAML file.
| "\n", | ||
| "landuse_file = r\"C:\\projects\\sandag\\av_tnc_routing\\av_run_dir\\tnc_routing_data\\final_land_use.csv\"\n", | ||
| "omx_path = r\"C:\\projects\\sandag\\av_tnc_routing\\av_run_dir\\input_data_full\\skims\\traffic_skims_MD.omx\"\n", | ||
| "skim_core = \"SOV_TR_H_DIST__MD\"" |
There was a problem hiding this comment.
The skim_core is different from settings as default setting is shared-ride 2 high value-of-time skim.
| def write_outputs(self, tnc_veh_trips, pooled_trips, id_mapping_df): | ||
| """Write final tables to output folder""" | ||
| tnc_veh_trips.to_csv( | ||
| os.path.join(self.settings.output_dir, "output_tnc_vehicle_trips.csv"), |
There was a problem hiding this comment.
Is this output file equivalent to the old TNCTrips.csv? If yes, could you rename it to use the same file name as before?
| index=True, | ||
| ) | ||
| pooled_trips.to_csv( | ||
| os.path.join(self.settings.output_dir, "output_tnc_pooled_trips.csv"), |
There was a problem hiding this comment.
I didn’t notice the pooled trips output referenced in the TNC summaries. Is it already captured in output_tnc_vehicle_trips?
|
Were the demand matrix files produced using the updated model as well? i.e. TNCVehicleTrips_[time_period].omx and emptyAVTrips.omx |
Draft PR of initial code implementation of both the intra-household AV allocation and taxi/TNC routing models.
Mode detailed description of code changes forthcoming.