Improve DOS copy for data exporter #381
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Based on issue SANDAG#374 (SANDAG#374). Copying model data from C: drive back to T: drive has been taking longer and occasionally failing. This PR modifies the script to improve copy speed of all non-EMME specific files and prioritizes copy of all non-EMME specific files over EMME files and directories. > ## Types of changes > What types of changes does your code introduce? _Put an `x` in the boxes that apply_ > > * [ ] Bugfix (non-breaking change which fixes an issue) > * [x] New feature (non-breaking change which adds functionality) > * [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) > * [ ] Documentation Update (if none of the other choices apply) > > ## How has this been tested? > Please describe the tests that you ran to verify your changes. > > * [x] Ran a partial 2050 run with data export step included. > > ## Checklist: > * [x] My code follows the style guidelines of this project > * [x] I have performed a self-review of my own code > * [x] I have commented my code, particularly in hard-to-understand areas > * [ ] I have made corresponding changes to the documentation > * [ ] My changes generate no new warnings > > ## Further comments > The new copy method has different error codes when compared to the previous method. A return code other than 0 or 1 is not an immediate flag, but should be examined.
JiaXu1024
reviewed
Nov 5, 2025
aber-sandag
requested changes
Nov 18, 2025
| # windows xcopy is much faster than shutil | ||
| # upgrading xcopy to a faster robocopy | ||
| self._report.append(_time.strftime("%c")) | ||
| exclude_filename = "TEMP_file_manager_exclude.txt" |
Contributor
There was a problem hiding this comment.
exclude_file and exclude_filename can be removed, as these were only needed for xcopy. Only need exclude_file_list for robocopy
| self.log_report() | ||
| raise | ||
| self._report.append(output) | ||
| if (error.returncode < 16) and (error.returncode > 0): |
Contributor
There was a problem hiding this comment.
Check return code >=8 to indicate an error, remove duplicate report append
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Based on issue #374. Copying model data from C: drive back to T: drive has been taking longer and occasionally failing. This PR modifies the script to improve copy speed of all non-EMME specific files and prioritizes copy of all non-EMME specific files over EMME files and directories.
Impact
Replaces
xcopyDOS command withrobocopy(with a copy speed of ~7,500 MegaBytes/min).Types of changes
What types of changes does your code introduce to ABM?
Put an
xin the boxes that applyHow has this been tested?
Please describe the tests that you ran to verify your changes.
Checklist:
Further comments
The new copy method has different error codes when compared to the previous method. A return code other than 0 or 1 is not an immediate flag and is coded to not raise an error but should be examined. Error code 16 (no files were copied over) will be raised.