-
Notifications
You must be signed in to change notification settings - Fork 72
File Format for MSAG (Message Class) #720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yanapu-jyothi
wants to merge
11
commits into
SAP:main
Choose a base branch
from
yanapu-jyothi:feature/msag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+150
−0
Open
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
294a89e
Add files for MSAG
yanapu-jyothi 61787f3
Merge branch 'SAP:main' into feature/msag
yanapu-jyothi b285d8a
Modified files for MSAG
yanapu-jyothi 91e906a
Merge branch 'SAP:main' into feature/msag
yanapu-jyothi 4d1d249
Update file-formats/msag/type/zif_aff_msag_v1.intf.abap
yanapu-jyothi 92154a6
React to abaplint
yanapu-jyothi 943988d
Update README.md
yanapu-jyothi 19bc998
Incorporating review comments
yanapu-jyothi 9efccc1
Incorporating review comment
yanapu-jyothi 3dc04fd
Modifying the header type without lang version
yanapu-jyothi c4f9fd5
Update file-formats/msag/type/zif_aff_msag_v1.intf.abap
yanapu-jyothi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # Message Class File Format | ||
|
|
||
| ## Object Type Information | ||
|
|
||
| Object Type | Description | Group | ||
| :--- | :--- | :--- | ||
| MSAG | Message Class | Texts | ||
|
|
||
| ## File Structure | ||
|
|
||
| File | Cardinality | Definition | Schema | Example | ||
| :--- | :--- | :--- | :--- | :--- | ||
| `<name>.msag.json` | 1 | [`zif_aff_msag_v1.intf.abap`](./type/zif_aff_msag_v1.intf.abap) | [`msag-v1.json`](./msag-v1.json) | [`z_aff_example_msag.msag.json`](./examples/z_aff_example_msag.msag.json) | ||
|
|
||
| --- | ||
|
|
||
| **Note:** | ||
| Long text support is not currently included in the ABAP file format. However, support for long text will be added in a future version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "formatVersion": "1", | ||
| "header": { | ||
| "description": "Example message class object for ABAP File Formats", | ||
| "originalLanguage": "en" | ||
| }, | ||
| "messages": [ | ||
| { | ||
| "number": "000", | ||
| "text": "Data saved successfully" | ||
| }, | ||
| { | ||
| "number": "001", | ||
| "text": "Invalid input: &1" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| { | ||
| "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.", | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/msag/msag-v1.json", | ||
| "title": "Message Class Properties", | ||
| "description": "Message class properties", | ||
| "type": "object", | ||
| "properties": { | ||
| "formatVersion": { | ||
| "title": "ABAP File Format Version", | ||
| "description": "The ABAP file format version", | ||
| "type": "string", | ||
| "const": "1" | ||
| }, | ||
| "header": { | ||
| "title": "Header", | ||
| "description": "Header", | ||
| "type": "object", | ||
| "properties": { | ||
| "description": { | ||
| "title": "Description", | ||
| "description": "Description of the ABAP object", | ||
| "type": "string", | ||
| "maxLength": 60 | ||
| }, | ||
| "originalLanguage": { | ||
| "title": "Original Language", | ||
| "description": "Original language of the ABAP object", | ||
| "type": "string", | ||
| "minLength": 2 | ||
| }, | ||
| "abapLanguageVersion": { | ||
| "title": "ABAP Language Version", | ||
| "description": "ABAP language version", | ||
| "type": "string", | ||
| "enum": [ | ||
| "standard", | ||
| "keyUser", | ||
| "cloudDevelopment" | ||
| ], | ||
| "enumTitles": [ | ||
| "Standard", | ||
| "ABAP for Key Users", | ||
| "ABAP Cloud Development" | ||
| ], | ||
| "enumDescriptions": [ | ||
| "Standard", | ||
| "ABAP for key user extensibility", | ||
| "ABAP cloud development" | ||
| ], | ||
| "default": "standard" | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "description", | ||
| "originalLanguage" | ||
| ] | ||
| }, | ||
| "messages": { | ||
| "title": "Messages", | ||
| "description": "Messages", | ||
| "type": "array", | ||
| "items": { | ||
| "title": "Message Properties", | ||
| "description": "Message properties", | ||
| "type": "object", | ||
| "properties": { | ||
| "number": { | ||
| "title": "Message Number", | ||
| "description": "Message number", | ||
| "type": "string", | ||
| "maxLength": 3 | ||
| }, | ||
| "text": { | ||
| "title": "Short Text", | ||
| "description": "Short text", | ||
| "type": "string", | ||
| "maxLength": 73 | ||
| } | ||
| }, | ||
| "additionalProperties": false | ||
| } | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "formatVersion", | ||
| "header", | ||
| "messages" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| INTERFACE zif_aff_msag_v1 | ||
| PUBLIC. | ||
|
|
||
| TYPES: | ||
| "! <p class="shorttext">Message Properties</p> | ||
| "! Message properties | ||
| BEGIN OF ty_message, | ||
| "! <p class="shorttext">Message Number</p> | ||
| "! Message number | ||
| number TYPE c LENGTH 3, | ||
| "! <p class="shorttext">Short Text</p> | ||
| "! Short text | ||
| text TYPE c LENGTH 73, | ||
| END OF ty_message. | ||
|
|
||
| "! <p class="shorttext">Internal table to store messages</p> | ||
| "! Internal table to store messages | ||
| TYPES ty_messages TYPE STANDARD TABLE OF ty_message WITH DEFAULT KEY. | ||
|
|
||
| TYPES: | ||
| "! <p class="shorttext">Message Class Properties</p> | ||
| "! Message class properties | ||
| BEGIN OF ty_main, | ||
| "! $required | ||
| format_version TYPE zif_aff_types_v1=>ty_format_version, | ||
| "! <p class="shorttext">Header</p> | ||
| "! Header | ||
| "! $required | ||
| header TYPE zif_aff_types_v1=>ty_header_60, | ||
Markus1812 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| "! <p class="shorttext">Messages</p> | ||
| "! Messages | ||
| "! $required | ||
| messages TYPE ty_messages, | ||
| END OF ty_main. | ||
|
|
||
| ENDINTERFACE. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "formatVersion": "1", | ||
| "header": { | ||
| "description": "AFF type for Message Class Object", | ||
| "originalLanguage": "en" | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.