chore: Explicit no-convenience; Add code usage examples #340
+42
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarified the warning about model and client classes generated from OpenAPI specifications, emphasizing stability and maintenance.
Clarified stability and maintenance of generated classes.
Added examples for document creation and search using the Vector API.
Added examples for collection and document creation using the Vector API.
newtork
commented
Jan 7, 2026
newtork
commented
Jan 7, 2026
| .key("animal").value("dog"))) | ||
| .metadata(DocumentKeyValueListPair.create() | ||
| .key("topic").value("sound"))); | ||
| DocumentsListResponse response = api.createDocuments(resourceGroupId, collectionId, request); |
Contributor
There was a problem hiding this comment.
Document creation is not compiling
Contributor
There was a problem hiding this comment.
var request =
DocumentCreateRequest.create()
.documents(
BaseDocument.create()
.chunks(
TextOnlyBaseChunk.create()
.content("The dog makes _woof_")
.metadata(VectorKeyValueListPair.create().key("animal").value("dog")))
.metadata(VectorDocumentKeyValueListPair.create().key("topic").value("sound")));
Comment on lines
+82
to
+84
| Collection creation: | ||
|
|
||
| ``` |
Contributor
There was a problem hiding this comment.
Suggested change
| Collection creation: | |
| ``` | |
| #### Collection creation: | |
| ```java |
| String collectionId = locationHeader.replaceAll("^.*?/([a-f0-9-]+)/.*?$", "$1"); | ||
| ``` | ||
|
|
||
| Document creation: |
Contributor
There was a problem hiding this comment.
Suggested change
| Document creation: | |
| #### Document creation: |
| DocumentsListResponse response = api.createDocuments(resourceGroupId, collectionId, request); | ||
| ``` | ||
|
|
||
| Document search: |
Contributor
There was a problem hiding this comment.
Suggested change
| Document search: | |
| #### Document search: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Has Changed?
See
SAP/ai-sdk-java#673
SAP/ai-sdk-java#672
SAP/ai-sdk-java#678