Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adapt Deploy Config Inquirer and Deploy Config Sub Generator to support ADP Projects #2603

Merged
merged 138 commits into from
Mar 20, 2025
Merged

feat: Adapt Deploy Config Inquirer and Deploy Config Sub Generator to support ADP Projects #2603

merged 138 commits into from
Mar 20, 2025
+1,218 −133

Conversation

GDamyanov
Copy link
Contributor

@GDamyanov GDamyanov commented Nov 20, 2024 •
edited
Loading

Feat for #2600

  • Adapt Deploy Config Inquirer and Deploy Config Sub Generator to support ADP Projects

cianmSAP and others added 2 commits November 14, 2024 18:25
@cianmSAP
feat(abap-inq): updates abap inquirer options and conditions
Loading
Loading status checks…
7cf79a4
@GDamyanov
feat: add validations
Loading
Loading status checks…
cb2a88a
@GDamyanov GDamyanov self-assigned this Nov 20, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: f507e92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/create Patch
@sap-ux/deploy-config-sub-generator Patch
@sap-ux/ui-service-inquirer Patch
@sap-ux/ui-service-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GDamyanov
fix: add parameter
Loading
Loading status checks…
b56d409
@GDamyanov
feat: add validation to
Loading
Loading status checks…
d843133
@GDamyanov GDamyanov requested a review from cianmSAP November 20, 2024 14:51
Base automatically changed from feat/abap-inq/2570-conditions-validators-updates to main November 26, 2024 14:45
@GDamyanov GDamyanov closed this Nov 27, 2024
@GDamyanov GDamyanov reopened this Dec 2, 2024
GDamyanov and others added 7 commits December 2, 2024 11:17
@GDamyanov
Merge branch 'main' into feat/2600/deploy-inq-validators-updates

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
fb3c56d
@GDamyanov
feat: add additional validation
Loading
Loading status checks…
e9f42f1
@GDamyanov
fix: fix tests
Loading
Loading status checks…
b2ca86e
@GDamyanov
test: add tests
Loading
Loading status checks…
0c2489c
@GDamyanov
Merge branch 'main' into feat/2600/deploy-inq-validators-updates

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
f86b792
@GDamyanov
refactor: format
Loading
Loading status checks…
72289b8
@GDamyanov
fix: lint errors
Loading
Loading status checks…
0584cf9
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@GDamyanov
fix: await function
Loading
Loading status checks…
b0f2adc
@GDamyanov GDamyanov requested a review from a team as a code owner December 9, 2024 09:01
@GDamyanov GDamyanov requested a review from a team as a code owner December 12, 2024 08:26
@GDamyanov
Merge branch 'main' into feat/2600/deploy-inq-validators-updates

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
594cd99
@GDamyanov GDamyanov marked this pull request as draft December 19, 2024 11:26
GDamyanov and others added 6 commits January 27, 2025 15:30
@GDamyanov
Merge branch 'main' into feat/2600/deploy-inq-validators-updates

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
c77f601
@GDamyanov
Merge branch 'main' into feat/2600/deploy-inq-validators-updates

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
a2c170b
@GDamyanov
Merge branch 'main' into feat/2600/deploy-inq-validators-updates

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
f92d27d
@GDamyanov
feat: update conditions
Loading
Loading status checks…
fd41b9e
@GDamyanov
fix: build
Loading
Loading status checks…
3bfa28b
@GDamyanov
test: fix tests
Loading
Loading status checks…
5630d93
lfindlaysap
lfindlaysap previously approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@lfindlaysap lfindlaysap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GDamyanov, thanks for making the changes.

@GDamyanov
Merge branch 'main' into feat/2600/deploy-inq-validators-updates

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
854c0df
@JannaLisa
Copy link

Thanks @GDamyanov, looks good now!

JannaLisa
JannaLisa previously approved these changes Mar 19, 2025
View reviewed changes
Copy link

@JannaLisa JannaLisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go now!

longieirl
longieirl previously approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving.

@GDamyanov
Merge branch 'main' into feat/2600/deploy-inq-validators-updates

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
4badb3e
cianmSAP
cianmSAP previously approved these changes Mar 19, 2025
View reviewed changes
donal-tobin-sap
donal-tobin-sap previously approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@donal-tobin-sap donal-tobin-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be fine from devops side.

tobiasqueck
tobiasqueck requested changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@tobiasqueck tobiasqueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ONLY reviewed the changes of the create module

  • code is clear and easy to understand
  • tests are missing: I would expect two tests, one with isAdp true and one with false or undefined

@GDamyanov
test: added tests
Loading
Loading status checks…
b079965
@GDamyanov GDamyanov requested a review from tobiasqueck March 20, 2025 08:49
@GDamyanov
Merge branch 'main' into feat/2600/deploy-inq-validators-updates

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
f507e92
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
92.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@GDamyanov GDamyanov merged commit 1bca2d8 into main Mar 20, 2025
27 checks passed
@GDamyanov GDamyanov deleted the feat/2600/deploy-inq-validators-updates branch March 20, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Klaus-Keller Klaus-Keller

@tobiasqueck tobiasqueck

@cianmSAP cianmSAP

@lfindlaysap lfindlaysap

@donal-tobin-sap donal-tobin-sap

@JannaLisa JannaLisa

@longieirl longieirl

Assignees

@GDamyanov GDamyanov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@GDamyanov @lfindlaysap @JannaLisa @donal-tobin-sap @longieirl @tobiasqueck @Klaus-Keller @cianmSAP