Skip to content

Centralize and increase TypeScript version and introduce erasableSyntaxOnly #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Mar 28, 2025
Merged

Centralize and increase TypeScript version and introduce erasableSyntaxOnly #3003

merged 23 commits into from
Mar 28, 2025

Conversation

heimwege
Copy link
Contributor

@heimwege heimwege commented Mar 6, 2025 •
edited
Loading

Update TypeScript version to 5.8.2, delete local typescript devDependencies in packages and introduce new compiler option erasableSyntaxOnly for preview-middleware

As SonarCloud does not yet support the new property this PR introduces a sonar specific tsconfig for preview-middleware w/o this property.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: a90962b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sap-ux/preview-middleware Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@heimwege heimwege added the preview-middleware @sap-ux/preview-middleware label Mar 6, 2025
@heimwege heimwege changed the title increase TypeScript version and introduce erasableSyntaxOnly Centralize and increase TypeScript version and introduce erasableSyntaxOnly Mar 13, 2025
@heimwege heimwege added store @sap-ux/store axios-extension @sap-ux/axios-extension environment-check @sap-ux/environment-check ui-components @sap-ux/ui-components telemetry @sap-ux/telemetry nodejs-utils @sap-ux/nodejs-utils related ui-prompting cf-deploy-config-sub-generator labels Mar 13, 2025
@heimwege heimwege marked this pull request as ready for review March 14, 2025 09:34
@heimwege heimwege requested review from a team as code owners March 14, 2025 09:34
nlunets
nlunets previously approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@nlunets nlunets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a changeset.
Changes looks good

@heimwege
Copy link
Contributor Author

There is a changeset. Changes looks good

but you missed the typo in the changeset 🙈 😄

wait, you're reading those ?

No but @johannes-kolbe did 🤓

johannes-kolbe
johannes-kolbe previously approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@johannes-kolbe johannes-kolbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • centralized typescript approach lg, comments discussed
  • sonar report available
  • changeset provided
  • did not test manually

heimwege added 2 commits March 20, 2025 14:36
@heimwege
Merge branch 'main' of github.com:SAP/open-ux-tools into feat/preview…
7863256 
…-middleware/introduce-erasableSyntaxOnly

# Conflicts:
#	pnpm-lock.yaml
@heimwege
Merge remote-tracking branch 'origin/feat/preview-middleware/introduc…
582794c 
…e-erasableSyntaxOnly' into feat/preview-middleware/introduce-erasableSyntaxOnly
johannes-kolbe
johannes-kolbe previously approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@johannes-kolbe johannes-kolbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving

Klaus-Keller
Klaus-Keller previously approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@Klaus-Keller Klaus-Keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @heimwege, TypeScript update looks good.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

voicis
voicis previously approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to annotation related packages looks good.

heimwege and others added 3 commits March 26, 2025 15:26
@heimwege
Merge branch 'main' into feat/preview-middleware/introduce-erasableSy…
42580cc 
…ntaxOnly
@heimwege
Merge branch 'main' of github.com:SAP/open-ux-tools into feat/preview…
34c151e 
…-middleware/introduce-erasableSyntaxOnly

# Conflicts:
#	package.json
#	pnpm-lock.yaml
@heimwege
Merge remote-tracking branch 'origin/feat/preview-middleware/introduc…
cccc506 
…e-erasableSyntaxOnly' into feat/preview-middleware/introduce-erasableSyntaxOnly
@heimwege heimwege dismissed stale reviews from Klaus-Keller, johannes-kolbe, and voicis via cccc506 March 28, 2025 09:06
@heimwege
Copy link
Contributor Author

@voicis @Klaus-Keller @johannes-kolbe I had to resolve a merge conflict in package.json and pnpm-lock.json which dismissed your review could you please re-review?

Klaus-Keller
Klaus-Keller approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@Klaus-Keller Klaus-Keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approved

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@heimwege heimwege merged commit eebf808 into main Mar 28, 2025
16 checks passed
@heimwege heimwege deleted the feat/preview-middleware/introduce-erasableSyntaxOnly branch March 28, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voicis voicis voicis approved these changes

@Klaus-Keller Klaus-Keller Klaus-Keller approved these changes

@nlunets nlunets nlunets left review comments

@johannes-kolbe johannes-kolbe Awaiting requested review from johannes-kolbe

Assignees
No one assigned
Labels
axios-extension @sap-ux/axios-extension cf-deploy-config-sub-generator environment-check @sap-ux/environment-check nodejs-utils @sap-ux/nodejs-utils related preview-middleware @sap-ux/preview-middleware store @sap-ux/store telemetry @sap-ux/telemetry ui-components @sap-ux/ui-components ui-prompting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@heimwege @nlunets @voicis @Klaus-Keller @johannes-kolbe