fix: set timeout in before all #3007
Merged
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
devinea
approved these changes
Mar 10, 2025
|
eouin
added a commit
that referenced
this pull request
Mar 12, 2025
…onents/ui-inputtranslation-inverted-theme * 'main' of github.com:SAP/open-ux-tools: fix: set timeout in before all (#3007) chore: apply latest changesets fix(ui-components): UISections. Error `Cannot read properties of undefined (reading 'size')` is throws for section on initial rendering (#3014) chore: apply latest changesets feat(preview-middleware):refactor lrep connectors in preview middleware (#3009) chore: apply latest changesets fix(deploy-config): fix errors running standalone (#3012) chore: apply latest changesets fix(deps): update dependency axios to v1.8.2 [security] (#3005) chore: apply latest changesets fix(deploy-config-sub-generator): append destination to backendconfig (#3011) chore: apply latest changesets fix(deploy-gen): fix undefined error when no backend config found (#3008) chore: apply latest changesets fix(cf-deploy-config-writer): add more tests based on testing with CDS generated mta's (#2998) chore: apply latest changesets fix(project-integrity): ensure encoded write for project-integrity (#3004) chore: apply latest changesets fix(project-access): Improve `getModule` to attempt module reinstallation if loading fails (#3000)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Timeout was set in config which effects all tests timeout.More on timeout.
If there was any failure, playwright would re-try one more time after waiting
5 min + 30 secondand this caused timeout in pipeline which has only 30 min. Playwright report artifacts were not uploaded due to pipeline time out.Possible solution:
Add time out only in
beforeAllwhich affects only before all. More on this check..