-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(preview-middleware):refactor lrep connectors in preview middleware #3009
feat(preview-middleware):refactor lrep connectors in preview middleware #3009
Conversation
🦋 Changeset detectedLatest commit: 5489a3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…om init connectors
…tors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't look completely wrong and remove something which looked very wrong.
Has tests.
Sonar is happy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changeset is good.
Tests are good.
Change is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good
Coverage is good
Changeset is good
Tested locally, although we will ask our QA to test it once more
…tors
…tors
|
…onents/ui-inputtranslation-inverted-theme * 'main' of github.com:SAP/open-ux-tools: fix: set timeout in before all (#3007) chore: apply latest changesets fix(ui-components): UISections. Error `Cannot read properties of undefined (reading 'size')` is throws for section on initial rendering (#3014) chore: apply latest changesets feat(preview-middleware):refactor lrep connectors in preview middleware (#3009) chore: apply latest changesets fix(deploy-config): fix errors running standalone (#3012) chore: apply latest changesets fix(deps): update dependency axios to v1.8.2 [security] (#3005) chore: apply latest changesets fix(deploy-config-sub-generator): append destination to backendconfig (#3011) chore: apply latest changesets fix(deploy-gen): fix undefined error when no backend config found (#3008) chore: apply latest changesets fix(cf-deploy-config-writer): add more tests based on testing with CDS generated mta's (#2998) chore: apply latest changesets fix(project-integrity): ensure encoded write for project-integrity (#3004) chore: apply latest changesets fix(project-access): Improve `getModule` to attempt module reinstallation if loading fails (#3000)
Refactoring of the lrep connectors. Needed for #2967
Without this change the linked PR tries to read the connector from the UI5 sources and randomly completely crashed the flp


With the changes in this PR those 404 calls are gone.