Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preview-middleware):refactor lrep connectors in preview middleware #3009

Merged
merged 8 commits into from
Mar 11, 2025

Conversation

heimwege
Copy link
Contributor

@heimwege heimwege commented Mar 10, 2025

Refactoring of the lrep connectors. Needed for #2967

Without this change the linked PR tries to read the connector from the UI5 sources and randomly completely crashed the flp
image
image

With the changes in this PR those 404 calls are gone.

Copy link

changeset-bot bot commented Mar 10, 2025

🦋 Changeset detected

Latest commit: 5489a3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux-private/preview-middleware-client Patch
@sap-ux/preview-middleware Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@heimwege heimwege marked this pull request as ready for review March 10, 2025 11:27
@heimwege heimwege requested a review from a team as a code owner March 10, 2025 11:27
@nikmace nikmace requested a review from a team March 10, 2025 11:28
…om init connectors
@heimwege heimwege marked this pull request as draft March 10, 2025 13:26
@heimwege heimwege marked this pull request as ready for review March 10, 2025 15:37

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…tors
Copy link
Member

@nlunets nlunets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look completely wrong and remove something which looked very wrong.
Has tests.
Sonar is happy.

Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changeset is good.
Tests are good.
Change is good.

Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good
Coverage is good
Changeset is good
Tested locally, although we will ask our QA to test it once more

nikmace and others added 2 commits March 11, 2025 09:10

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…tors

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…tors
@heimwege heimwege merged commit 32dafd7 into main Mar 11, 2025
16 checks passed
@heimwege heimwege deleted the feat/preview-middleware/refactor-lrep-connectors branch March 11, 2025 09:15
eouin added a commit that referenced this pull request Mar 12, 2025
…onents/ui-inputtranslation-inverted-theme

* 'main' of github.com:SAP/open-ux-tools:
  fix: set timeout in before all (#3007)
  chore: apply latest changesets
  fix(ui-components): UISections. Error `Cannot read properties of undefined (reading 'size')` is throws for section on initial rendering  (#3014)
  chore: apply latest changesets
  feat(preview-middleware):refactor lrep connectors in preview middleware (#3009)
  chore: apply latest changesets
  fix(deploy-config): fix errors running standalone (#3012)
  chore: apply latest changesets
  fix(deps): update dependency axios to v1.8.2 [security] (#3005)
  chore: apply latest changesets
  fix(deploy-config-sub-generator): append destination to backendconfig (#3011)
  chore: apply latest changesets
  fix(deploy-gen): fix undefined error when no backend config found (#3008)
  chore: apply latest changesets
  fix(cf-deploy-config-writer): add more tests based on testing with CDS generated mta's (#2998)
  chore: apply latest changesets
  fix(project-integrity): ensure encoded write for project-integrity (#3004)
  chore: apply latest changesets
  fix(project-access): Improve `getModule` to attempt module reinstallation if loading fails (#3000)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants