Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3022/expose app frontend router #3028

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

longieirl
Copy link
Contributor

@longieirl longieirl commented Mar 14, 2025

STILL A WORK IN PROGRESS

Fix for #3022

  • expose new app frontend mta configuration when adding a HTML5 application for HTML5 apps and/or CAP projects
  • tests updated, existing tests untouched confirming existing no impact on existing flow
  • sample projects created

Sample code;

import { generateAppConfig, DefaultMTADestination } from '@sap-ux/cf-deploy-config-writer'
import { join } from 'path';

const exampleWriter = async () => {
  const ui5AppPath = join(__dirname, 'testapp');
  const fs = await generateAppConfig({appPath: ui5AppPath, addAppFrontendRouter: true, destinationName: 'SAPBTPDestination'}); 
  return new Promise((resolve) => {
      fs.commit(resolve); // When using with Yeoman it handle the fs commit.
  });
}
// Calling the function
await exampleWriter();

@longieirl longieirl self-assigned this Mar 14, 2025
Copy link

changeset-bot bot commented Mar 14, 2025

🦋 Changeset detected

Latest commit: 5ec42a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux/cf-deploy-config-writer Minor
@sap-ux/cf-deploy-config-sub-generator Patch
@sap-ux/deploy-config-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@longieirl longieirl force-pushed the 3022/expose-app-frontend-router branch from 2b8665a to d6c2929 Compare March 14, 2025 14:50
@longieirl longieirl force-pushed the 3022/expose-app-frontend-router branch from 8632196 to 5ec42a3 Compare March 25, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant