-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Report telemetry for Quick Actions and Fragments Creation #3030
Conversation
🦋 Changeset detectedLatest commit: 6da8d61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ickActions
…SAP/open-ux-tools into fix/addTelemetryForQuickActions
packages/preview-middleware-client/src/adp/controllers/ExtensionPoint.controller.ts
Outdated
Show resolved
Hide resolved
packages/preview-middleware-client/src/cpe/quick-actions/quick-action-service.ts
Outdated
Show resolved
Hide resolved
packages/preview-middleware-client/src/adp/controllers/ExtensionPoint.controller.ts
Outdated
Show resolved
Hide resolved
packages/preview-middleware-client/src/adp/controllers/BaseDialog.controller.ts
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Code changes looks good
- Review comments addressed
- Good test coverage
- Did not test manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good.
Tested with developer.
Unit test coverage looks good.
Approving
TelemetryData
withactionName
andtimestamp
fields for improved logging.executeAction()
inquick-action-service.ts
to log telemetry events.DialogFactory.ts
to ensure telemetry is correctly passed