Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Report telemetry for Quick Actions and Fragments Creation #3030

Merged
merged 32 commits into from
Mar 27, 2025

Conversation

KamalKumarSardiwal
Copy link
Contributor

@KamalKumarSardiwal KamalKumarSardiwal commented Mar 14, 2025

  • Report telemetry for quick action and on creation of fragments
  • Added TelemetryData with actionName and timestamp fields for improved logging.
  • Refactored executeAction() in quick-action-service.ts to log telemetry events.
  • Passed TelemetryData to all Quick Action controllers
  • Updated DialogFactory.ts to ensure telemetry is correctly passed
  • Moved telemetry identifier generation logic to QuickActionDefinitionBase class
  • Introduced getTelemetryIdentifier(update?: boolean) to manage ID updates internally
  • Updated executeAction in QuickActionService to use getTelemetryIdentifier(true)
  • Replaced direct references to telemetryEventIdentifier with method calls in affected Quick Actions
  • Adjusted test cases to align with the new implementation

@KamalKumarSardiwal KamalKumarSardiwal requested review from a team as code owners March 14, 2025 16:00
Copy link

changeset-bot bot commented Mar 14, 2025

🦋 Changeset detected

Latest commit: 6da8d61

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@sap-ux-private/control-property-editor-common Patch
@sap-ux-private/preview-middleware-client Patch
@sap-ux/preview-middleware Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

cla-assistant bot commented Mar 14, 2025

CLA assistant check
All committers have signed the CLA.

KamalKumarSardiwal and others added 7 commits March 14, 2025 17:18

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…SAP/open-ux-tools into fix/addTelemetryForQuickActions
@KamalKumarSardiwal KamalKumarSardiwal changed the title fix: Add telemetry for Quick Actions fix: Add telemetry for Quick Actions and Fragments Creation Mar 18, 2025
@KamalKumarSardiwal KamalKumarSardiwal changed the title fix: Add telemetry for Quick Actions and Fragments Creation fix: Report telemetry for Quick Actions and Fragments Creation Mar 18, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…SAP/open-ux-tools into fix/addTelemetryForQuickActions

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…SAP/open-ux-tools into fix/addTelemetryForQuickActions

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
KamalKumarSardiwal and others added 2 commits March 24, 2025 17:54

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…SAP/open-ux-tools into fix/addTelemetryForQuickActions

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code changes looks good
  • Review comments addressed
  • Good test coverage
  • Did not test manually

Copy link
Contributor

@Jimmy-Joseph19 Jimmy-Joseph19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.
Tested with developer.
Unit test coverage looks good.
Approving

@KamalKumarSardiwal KamalKumarSardiwal merged commit 6cedb61 into main Mar 27, 2025
16 checks passed
@KamalKumarSardiwal KamalKumarSardiwal deleted the fix/addTelemetryForQuickActions branch March 27, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants