Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generator-adp): Create a yeoman package for Adaptation Project generator #3031

Merged
merged 43 commits into from
Mar 26, 2025

Conversation

nikmace
Copy link
Contributor

@nikmace nikmace commented Mar 17, 2025

Feat for #3015.

  • Adds a new yeoman package which creates an Adaptation Project.
  • System and application prompts have been added from the start. The rest of the properties are filled from defaults

@nikmace nikmace self-assigned this Mar 17, 2025
@nikmace nikmace requested review from a team as code owners March 17, 2025 06:11
@nikmace nikmace linked an issue Mar 17, 2025 that may be closed by this pull request
2 tasks
Copy link

changeset-bot bot commented Mar 17, 2025

🦋 Changeset detected

Latest commit: 1cd4977

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@sap-ux/generator-adp Minor
@sap-ux/axios-extension Patch
@sap-ux/inquirer-common Patch
@sap-ux/adp-tooling Patch
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/app-config-writer Patch
@sap-ux/backend-proxy-middleware Patch
@sap-ux/deploy-config-sub-generator Patch
@sap-ux/deploy-tooling Patch
@sap-ux/environment-check Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/preview-middleware Patch
@sap-ux/system-access Patch
@sap-ux/ui-service-inquirer Patch
@sap-ux/ui-service-sub-generator Patch
@sap-ux/odata-cli Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/cf-deploy-config-inquirer Patch
@sap-ux/cf-deploy-config-sub-generator Patch
@sap-ux/create Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/flp-config-sub-generator Patch
@sap-ux/ui5-application-inquirer Patch
@sap-ux/ui5-library-inquirer Patch
@sap-ux/ui5-library-reference-inquirer Patch
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/abap-deploy-config-writer Patch
@sap-ux/ui5-library-sub-generator Patch
@sap-ux/ui5-library-reference-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@lfindlaysap lfindlaysap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikmace, here are my suggestions and comments.

nikmace and others added 7 commits March 17, 2025 14:24
Co-authored-by: Louise Findlay <[email protected]>
@nikmace
Copy link
Contributor Author

nikmace commented Mar 18, 2025

@nikmace, here are my suggestions and comments.

Heya @lfindlaysap, sorry, maybe I should've made this PR a draft. All of the above text will be removed, I have yet to refactor it/decide what it's gonna be. Thanks 👍🏻

nikmace and others added 2 commits March 18, 2025 09:05
nikmace and others added 11 commits March 19, 2025 12:34
@nikmace nikmace requested review from devinea and cianmSAP March 24, 2025 14:03
nikmace added 3 commits March 24, 2025 16:22
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to axios-extension, inquirier-common look good.
Adding new generator-adp, module set-up looks good.
Changeset ✅

@cianmSAP / @IainSAP - Please review generator.

nikmace and others added 3 commits March 25, 2025 07:21
@nikmace nikmace requested a review from cianmSAP March 25, 2025 14:40
cianmSAP
cianmSAP previously approved these changes Mar 25, 2025
Copy link
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New module/generator looks good
Comments addressed
Changesets look appropriate

@nikmace nikmace requested review from devinea and lfindlaysap March 26, 2025 07:22
Copy link
Contributor

@lfindlaysap lfindlaysap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikmace, thanks for updating the texts. Here is my revised review based on the new changes you made.

@nikmace
Copy link
Contributor Author

nikmace commented Mar 26, 2025

@lfindlaysap I've pushed a commit 9058f92 with the requested changes.

@nikmace nikmace requested a review from lfindlaysap March 26, 2025 10:12
Copy link
Contributor

@lfindlaysap lfindlaysap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikmace, awesome 🚀. Approved.

Copy link
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to axios-extension, inquirier-common look good.
Adding new generator-adp, module set-up looks good.
Changeset ✅

Copy link
Contributor

@testojs testojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new adaptation project generator module covering the agreed initial scope is added and looks good. It was tested manually and works as expected.

@nikmace nikmace merged commit ced5edf into main Mar 26, 2025
16 checks passed
@nikmace nikmace deleted the feat/3015/adp-generator-package branch March 26, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE - Move Adaptation Project generator code
5 participants