-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(generator-adp): Create a yeoman package for Adaptation Project generator #3031
Conversation
🦋 Changeset detectedLatest commit: 1cd4977 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikmace, here are my suggestions and comments.
packages/generator-adp/src/translations/adp-generator.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/adp-generator.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/adp-generator.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/adp-generator.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/adp-generator.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/adp-generator.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/adp-generator.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/adp-generator.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/adp-generator.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/adp-generator.i18n.json
Outdated
Show resolved
Hide resolved
Heya @lfindlaysap, sorry, maybe I should've made this PR a draft. All of the above text will be removed, I have yet to refactor it/decide what it's gonna be. Thanks 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New module/generator looks good
Comments addressed
Changesets look appropriate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikmace, thanks for updating the texts. Here is my revised review based on the new changes you made.
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
@lfindlaysap I've pushed a commit 9058f92 with the requested changes. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikmace, awesome 🚀. Approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to axios-extension, inquirier-common look good.
Adding new generator-adp, module set-up looks good.
Changeset ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new adaptation project generator module covering the agreed initial scope is added and looks good. It was tested manually and works as expected.
Feat for #3015.