Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add new generic change type and generic component for UI display #3034

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Add new generic change type and generic component for UI display #3034

wants to merge 1 commit into from

Conversation

Jimmy-Joseph19
Copy link
Contributor

Add new generic component and handle changes generically for change types

@Jimmy-Joseph19 Jimmy-Joseph19 requested review from a team as code owners March 18, 2025 10:26
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2025

⚠️ No Changeset found

Latest commit: 739bb5f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Jimmy-Joseph19 Jimmy-Joseph19 changed the title Add new generic change type and generic component for UI display fix: Add new generic change type and generic component for UI display Mar 18, 2025
lfindlaysap
lfindlaysap requested changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@lfindlaysap lfindlaysap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jimmy-Joseph19, some questions and suggestions.

packages/preview-middleware-client/src/messagebundle.properties
GENERIC_CHANGE_TITLE=Title
ANNOTATION_FILE_URI=Annotation File
RENAME_CHANGE=Rename Change
SELECTOR_ID=Selector Id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SELECTOR_ID=Selector Id
SELECTOR_ID=Selector ID

packages/preview-middleware-client/src/messagebundle.properties
NEW_VALUE=New value
TEXT_TYPE=Text Type
MOVE_CONTROLS_CHANGE=Move Controls Change
MOVED_CONTROL_ID=Control Id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MOVED_CONTROL_ID=Control Id
MOVED_CONTROL_ID=Control ID

packages/preview-middleware-client/src/messagebundle.properties
NEW_VALUE=New value
MOVE_FROM_INDEX=Move from
MOVE_TO_INDEX=Move to
TARGET_CONTROL_ID=Target Id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TARGET_CONTROL_ID=Target Id
TARGET_CONTROL_ID=Target ID

packages/preview-middleware-client/src/messagebundle.properties
ANNOTATION_FILE_URI=Annotation File
RENAME_CHANGE=Rename Change
SELECTOR_ID=Selector Id
NEW_VALUE=New value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you show me where this appears so I can tell if value should be capitalized?

packages/preview-middleware-client/src/messagebundle.properties
TEXT_TYPE=Text Type
MOVE_CONTROLS_CHANGE=Move Controls Change
MOVED_CONTROL_ID=Control Id
NEW_VALUE=New value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you show me where this appears so I can tell if value should be capitalized?

packages/preview-middleware-client/src/messagebundle.properties
MOVE_CONTROLS_CHANGE=Move Controls Change
MOVED_CONTROL_ID=Control Id
NEW_VALUE=New value
MOVE_FROM_INDEX=Move from
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you show me where this appears so I can tell if from should be capitalized?

packages/preview-middleware-client/src/messagebundle.properties
MOVED_CONTROL_ID=Control Id
NEW_VALUE=New value
MOVE_FROM_INDEX=Move from
MOVE_TO_INDEX=Move to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you show me where this appears so I can tell if to should be capitalized?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
68.4% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfindlaysap lfindlaysap lfindlaysap requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jimmy-Joseph19 @lfindlaysap