Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-service-inq): ensure correct package value is used for getContent request #3036

Merged
merged 3 commits into from
Mar 18, 2025

Conversation

docirl
Copy link
Contributor

@docirl docirl commented Mar 18, 2025

#3035

  • update condition logic to ensure correct value is passed to getContent request
  • update test to cover flow

@docirl docirl self-assigned this Mar 18, 2025
Copy link

changeset-bot bot commented Mar 18, 2025

🦋 Changeset detected

Latest commit: 3c278e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sap-ux/ui-service-sub-generator Patch
@sap-ux/ui-service-inquirer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
Update for known issue with empty strings
Changeset

Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changeset is good.
Updated tests.
Small code change.

@docirl docirl merged commit a566e73 into main Mar 18, 2025
16 checks passed
@docirl docirl deleted the fix/3035/service-inq-existing-package branch March 18, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants