Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generator-adp): Generator running in the CLI context #3049

Merged
merged 50 commits into from
Mar 30, 2025

Conversation

nikmace
Copy link
Contributor

@nikmace nikmace commented Mar 26, 2025

Fix for #3015.

  • Fixes generator flow when running with yo command in the CLI context.
  • Improves error handling for system prompt.
  • Fixed incorrect custom config generation.
  • Refactor classes to be standalone methods for less complexity.

@nikmace nikmace self-assigned this Mar 26, 2025
Copy link

changeset-bot bot commented Mar 26, 2025

🦋 Changeset detected

Latest commit: a07f988

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@sap-ux/generator-adp Patch
@sap-ux/adp-tooling Patch
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/create Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/preview-middleware Patch
@sap-ux/flp-config-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Base automatically changed from feat/3015/adp-generator-package to main March 26, 2025 12:09
@nikmace nikmace linked an issue Mar 26, 2025 that may be closed by this pull request
2 tasks
@nikmace nikmace marked this pull request as ready for review March 26, 2025 12:40
@nikmace nikmace requested a review from a team as a code owner March 26, 2025 12:40
@nikmace nikmace changed the title feat(generator-adp): Add validations and error handling to system and app configuration page fix(generator-adp): Generator running in the CLI context Mar 28, 2025
Copy link
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are very clear
Changeset looks good
Have not tested

Copy link
Contributor

@testojs testojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • code is improved
  • changeset OK
  • issue with the CLI resolved
  • tested manually and works as expected

@nikmace nikmace merged commit fbdf2d0 into main Mar 30, 2025
16 checks passed
@nikmace nikmace deleted the feat/3015/config-page-validations branch March 30, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE - Add Adaptation Project generator
3 participants