Skip to content

fiori-sub-gen: update FioriGeneratorPromptExtension types #3444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Jul 24, 2025

Conversation

cianmSAP
Copy link
Contributor

@cianmSAP cianmSAP commented Jul 15, 2025

  • Updates all prompt in the two sub gens - Deploy & FLP - to additionally support CommonPromptOptions.
  • Corrects prompt options logic in CF Inquirer to use hide property to determine whether a prompt is shown.
  • Deprecates FioriAppGeneratorOptions.extensions
  • Enhances FioriAppGeneratorPromptSettings used by FioriAppGeneratorOptions.promptSettings

Note - the goal is to eventually remove this logic, and for all extensions and adaptors to use FioriAppGeneratorOptions.promptSettings

Copy link

changeset-bot bot commented Jul 15, 2025

🦋 Changeset detected

Latest commit: 3eea2ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@sap-ux/abap-deploy-config-inquirer Minor
@sap-ux/cf-deploy-config-inquirer Minor
@sap-ux/flp-config-sub-generator Minor
@sap-ux/fiori-app-sub-generator Minor
@sap-ux/flp-config-inquirer Minor
@sap-ux/cf-deploy-config-sub-generator Patch
@sap-ux/deploy-config-sub-generator Patch
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/create Patch
@sap-ux/ui-service-inquirer Patch
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/generator-adp Patch
@sap-ux/ui-service-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cianmSAP cianmSAP force-pushed the fiori-sub-gen/extension-prompt-settings branch from 94cb993 to 3ecad42 Compare July 16, 2025 07:40
@cianmSAP cianmSAP requested a review from IainSAP July 22, 2025 16:29
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cianmSAP

  • Comments addressed
  • Alignment of types is moving in the right direction ;)

Copy link
Member

@kjose90 kjose90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cianmSAP - Nice work on aligning the types
changeset & tests ✅

Copy link

@cianmSAP cianmSAP merged commit 089b56f into main Jul 24, 2025
16 checks passed
@cianmSAP cianmSAP deleted the fiori-sub-gen/extension-prompt-settings branch July 24, 2025 09:17
devinea added a commit that referenced this pull request Jul 25, 2025
* origin/main: (46 commits)
  chore(deps): update dependency @types/inquirer-autocomplete-prompt to v2.0.2 (#1651)
  chore: apply latest changesets
  Fix UI5 1.120.x linting for basic template, fix warnings (#3434)
  fix: remove filtering of parameters for inbounds (#3440)
  chore: apply latest changesets
  fix: provide templates path parameter to handle different runtime context (#3464)
  chore: apply latest changesets
  fix(fiori-gen): updates FioriAppGeneratorPromptSettings type (#3474)
  chore: apply latest changesets
  fiori-sub-gen: update `FioriGeneratorPromptExtension` types (#3444)
  fix(deps): update jest monorepo to v30 (major) (#3362)
  chore: apply latest changesets
  fix(repo-app-import-sub-generator): set only css: [] in manifest to fix lint error (#3468)
  chore: apply latest changesets
  feat(odata-service-inq): set analytical table when supported by main entity (#3467)
  Project modules update 22.07.2025 (4690) (#3462)
  chore: apply latest changesets
  move headless AppConfig type and associated types to fiori gen shared module (#3466)
  fix: sonar issue for prompting examples (#3460)
  chore: delete cards editor middlewares (#3454)
  ...
devinea added a commit that referenced this pull request Jul 28, 2025
* origin/main:
  chore(deps): update dependency @types/inquirer-autocomplete-prompt to v2.0.2 (#1651)
  chore: apply latest changesets
  Fix UI5 1.120.x linting for basic template, fix warnings (#3434)
  fix: remove filtering of parameters for inbounds (#3440)
  chore: apply latest changesets
  fix: provide templates path parameter to handle different runtime context (#3464)
  chore: apply latest changesets
  fix(fiori-gen): updates FioriAppGeneratorPromptSettings type (#3474)
  chore: apply latest changesets
  fiori-sub-gen: update `FioriGeneratorPromptExtension` types (#3444)
  fix(deps): update jest monorepo to v30 (major) (#3362)
  chore: apply latest changesets
  fix(repo-app-import-sub-generator): set only css: [] in manifest to fix lint error (#3468)
  chore: apply latest changesets
  feat(odata-service-inq): set analytical table when supported by main entity (#3467)
  Project modules update 22.07.2025 (4690) (#3462)
  chore: apply latest changesets
  move headless AppConfig type and associated types to fiori gen shared module (#3466)
  fix: sonar issue for prompting examples (#3460)
  chore: delete cards editor middlewares (#3454)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants