-
Notifications
You must be signed in to change notification settings - Fork 45
fiori-sub-gen: update FioriGeneratorPromptExtension
types
#3444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 3eea2ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
94cb993
to
3ecad42
Compare
…hub.com/SAP/open-ux-tools into fiori-sub-gen/extension-prompt-settings
…hub.com/SAP/open-ux-tools into fiori-sub-gen/extension-prompt-settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cianmSAP
- Comments addressed
- Alignment of types is moving in the right direction ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cianmSAP - Nice work on aligning the types
changeset & tests ✅
|
* origin/main: (46 commits) chore(deps): update dependency @types/inquirer-autocomplete-prompt to v2.0.2 (#1651) chore: apply latest changesets Fix UI5 1.120.x linting for basic template, fix warnings (#3434) fix: remove filtering of parameters for inbounds (#3440) chore: apply latest changesets fix: provide templates path parameter to handle different runtime context (#3464) chore: apply latest changesets fix(fiori-gen): updates FioriAppGeneratorPromptSettings type (#3474) chore: apply latest changesets fiori-sub-gen: update `FioriGeneratorPromptExtension` types (#3444) fix(deps): update jest monorepo to v30 (major) (#3362) chore: apply latest changesets fix(repo-app-import-sub-generator): set only css: [] in manifest to fix lint error (#3468) chore: apply latest changesets feat(odata-service-inq): set analytical table when supported by main entity (#3467) Project modules update 22.07.2025 (4690) (#3462) chore: apply latest changesets move headless AppConfig type and associated types to fiori gen shared module (#3466) fix: sonar issue for prompting examples (#3460) chore: delete cards editor middlewares (#3454) ...
* origin/main: chore(deps): update dependency @types/inquirer-autocomplete-prompt to v2.0.2 (#1651) chore: apply latest changesets Fix UI5 1.120.x linting for basic template, fix warnings (#3434) fix: remove filtering of parameters for inbounds (#3440) chore: apply latest changesets fix: provide templates path parameter to handle different runtime context (#3464) chore: apply latest changesets fix(fiori-gen): updates FioriAppGeneratorPromptSettings type (#3474) chore: apply latest changesets fiori-sub-gen: update `FioriGeneratorPromptExtension` types (#3444) fix(deps): update jest monorepo to v30 (major) (#3362) chore: apply latest changesets fix(repo-app-import-sub-generator): set only css: [] in manifest to fix lint error (#3468) chore: apply latest changesets feat(odata-service-inq): set analytical table when supported by main entity (#3467) Project modules update 22.07.2025 (4690) (#3462) chore: apply latest changesets move headless AppConfig type and associated types to fiori gen shared module (#3466) fix: sonar issue for prompting examples (#3460) chore: delete cards editor middlewares (#3454)
CommonPromptOptions
.hide
property to determine whether a prompt is shown.FioriAppGeneratorOptions.extensions
FioriAppGeneratorPromptSettings
used byFioriAppGeneratorOptions.promptSettings
Note - the goal is to eventually remove this logic, and for all extensions and adaptors to use
FioriAppGeneratorOptions.promptSettings