Skip to content

fix: Fix info center layout issue #3453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

avasilev-sap
Copy link
Contributor

@avasilev-sap avasilev-sap commented Jul 17, 2025

Issue #3450

Change the logic for calculation the initial height of the info center based on the number of currently populated messages. Initially we set the height to be equal to the number of all messages multiplied by 100 which can lead to the described issue when a lot of messages are populated very fast at the start of the application. Each info center message has max 130px of height when the message contains a lot of text. So first it is better to use 130 instead of 100 px in case there is only one message at the start to avoid cutting the message content and to slightly change the height calculation: instead of all messages we use min(allMessagesCount, 3) * 130 - this will create a container initially which can accommodate at most 3 rows with max height - 130px. If the user is not satisfied with the size the splitter can be used for a manual resize.

Testing done: manually verified
info-center-layout

Copy link

changeset-bot bot commented Jul 17, 2025

⚠️ No Changeset found

Latest commit: b2348ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@avasilev-sap avasilev-sap marked this pull request as ready for review July 17, 2025 15:14
@avasilev-sap avasilev-sap requested a review from a team as a code owner July 17, 2025 15:14
Copy link
Contributor

@IvoSG IvoSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy to understand change
Code looks good
Did not test manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants