fix(OpenUI5Support): fix sap.m.Select inside a ui5-dialog #11939
Conversation
| change: function (oEvent) { | ||
| console.error("Selected item:", oEvent.getParameter("selectedItem").getText()); | ||
| } | ||
| }).placeAt("dilog1content"); |
There was a problem hiding this comment.
Is this a typo?
placeAt("dilog1content") > placeAt("dialog1content")
| @@ -81,6 +94,7 @@ | |||
| <ui5-button id="myButton">Open WebC Dialog</ui5-button> | |||
| </div> | |||
| <ui5-dialog id="dialog1" header-text="This is an WebC Dialog 1"> | |||
| <div id="dilog1content"></div> | |||
There was a problem hiding this comment.
Is this a typo?
"dilog1content" > "dialog1content"
| @@ -14,6 +16,24 @@ type OpenUI5Popup = { | |||
| } | |||
| }; | |||
|
|
|||
| // contains all OpenUI5 and Web Component popups that are currently opened | |||
There was a problem hiding this comment.
Alternatively, if you consider more descriptive:
Registry containing all currently opened OpenUI5 and Web Component popups.
There was a problem hiding this comment.
there 4 focus related bugs, but are not caused by the change (I will report them separately)
- if you replace the select with combobox, pressing escape closes the full dialog and not only the combobox popover. Similar behaviour can be reproduced if combobox is in ui5 dialog
- if you have combobox in openui5 dialog, start writing so that the popover appears - change the focus with Tab - there is a console error
- if you use keyboard only to open all dialogs, esc does not close the openui5 dialog properly
- the select is directly opened when the dialog is opened
| patchPopup, | ||
| addOpenedPopup, | ||
| removeOpenedPopup, | ||
| getTopMostPopup, |
There was a problem hiding this comment.
you can also use the single word "topmost", which means exactly this. Although "top most" is not too wrong either.
|
🎉 This PR is included in version v2.13.0-rc.2 🎉 The release is available on v2.13.0-rc.2 Your semantic-release bot 📦🚀 |
Organize all web components and OpenUI5 popups into a single array to ensure that focus is managed by the uppermost popup.
fixes #11933