Add configurable cluster domain support for non-standard Kubernetes environments #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #6 (comment)
The operator hardcoded
cluster.localas the DNS suffix, breaking deployments in Kubernetes clusters using custom domains (e.g.,kube.prod,k8s.mycorp.local). This caused DNS resolution failures in Sentinel and Valkey HA configurations.Changes:
API (
api/v1alpha1/types.go): Added optionalClusterDomainfield toValkeySpecwith DNS-compliant validation pattern and default valuecluster.localBinding logic (
pkg/operator/binding.go): Replaced hardcoded DNS suffix withvalkey.Spec.ClusterDomainin service hostname construction for both sentinel and non-sentinel modesHelm integration (
pkg/operator/data/parameters.yaml): PassedclusterDomainparameter to Bitnami chart and updated TLS certificate DNS SANs to use configurable domainDocumentation: Added usage example and field description to README
Usage:
Generates DNS names:
valkey-prod.namespace.svc.kube.prodinstead ofcluster.localBackward compatible—existing deployments continue using
cluster.localby default.Disclaimer : This PR was largely written with Copilot/Claude 4.5