addpanel method in grafana wrapper #91
Open
+99
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelfaulds
force-pushed
the
grafana-wrapper-addpanel
branch
from
e13e5c1 to
fd49949
Compare
Author
|
Test Example Dashboard Script After Changes |
Author
|
Test Example Dashboard Script Before Changes |
luuisabelle
reviewed
Jan 16, 2026
| stacking, | ||
| extraJson) | ||
|
|
||
| row_or_panel = self.rows[-1].panels if self.rows else self.panels |
Contributor
There was a problem hiding this comment.
assuming this new update doesn't allow for standalone panels w/o rows, we can probably simplify this to just
self.rows[-1].panels.append(panel)
luuisabelle
reviewed
Jan 16, 2026
| extraJson=None, | ||
| ): | ||
| ''' | ||
| Add panel to latest defined row |
Contributor
There was a problem hiding this comment.
maybe change this to "Add panel under a new defined row" for more clarity
luuisabelle
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Grafana Wrapper has AddPanel currently (which would add to row if defined, else panels). These updates add AddPanelToRow. No changes were needed for current dashboards. This makes it easier to switch back and forth between rows of multiple panels & stand alone panels.
Test Example Before Changes
Also if AddPanel() is used first, and Addrow() AddPanel() later then the initial AddPanels() might not get shown. This update prevents that from happening.
For example,
Test Example After Changes
After changes the gauge chart is no longer hidden and CPU Usage isn't placed into same row
SSH Tunnel Health Example After Changes