Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR integrates the libconfig library to enable configuration file support for the server application. The implementation reads server configuration parameters (max forks, thread count, file size limits, and timeouts) from an external config file.
- Adds libconfig dependency and configuration file parsing
- Introduces a config struct to store server parameters
- Updates build system and CI workflow to include libconfig dependency
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| server/main.c | Adds config struct, init_config_structure() function to parse config file, and integrates config loading into main(); also reorganizes includes |
| server/CMakeLists.txt | Links the libconfig library to the server executable |
| config.cfg | Defines server configuration parameters (max_forks, nb_threads, size_file_max, time_out) |
| CMakeLists.txt | Adds -lconfig linker flag to compiler flags (incorrect placement) |
| .github/workflows/build.yml | Installs libconfig-dev package in CI build environment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rheydskey
reviewed
Dec 7, 2025
Comment on lines
64
to
+85
| queue_destroy(&q); | ||
| return EXIT_FAILURE; | ||
| } | ||
| sem_post(sem_forks); |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Rheydskey
force-pushed
the
feat/parse_module
branch
from
eac6dc3 to
de8e2c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.