Conversation
Co-authored-by: b-at-neu <144247685+b-at-neu@users.noreply.github.com>
#41 Don't Allow Editing of Past Cycles
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
readOnlymode to both theAdminDashboardandNominationsManagercomponents, ensuring that when a cycle is inactive, users cannot perform actions that modify data. This helps prevent unintended changes during inactive cycles and improves the integrity of the nomination process. ThereadOnlyprop is propagated from the cycle dashboard based on the cycle's active status, and UI elements for destructive or modifying actions are hidden or disabled accordingly.Read-only mode for inactive cycles:
Added a
readOnlyprop toAdminDashboardandNominationsManager, defaulting tofalse, and passed it fromCycleDashboardbased oncycle.isActive. WhenreadOnlyistrue, UI elements for destructive or modifying actions (such as removing PDFs, rejecting nominations, or bulk approving) are hidden or disabled. [1] [2] [3] [4] app/admin/cycles/[id]/cycle-dashboard.tsxR106-R114)Updated the rendering logic in both components to conditionally display or hide action buttons, checkboxes, and instructional text based on the
readOnlystate, preventing users from making changes in inactive cycles. [1] [2] [3] [4] [5] [6] [7]Version bump:
1.5.0to1.5.1inpackage.jsonto reflect the new read-only functionality.