Skip to content

fix(export): replace fabricated results with real experiment data #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SHA888 wants to merge 5 commits into
base: main
Choose a base branch
from
+287 −97
Open

fix(export): replace fabricated results with real experiment data #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
01e9fbf
fix(export): replace fabricated results with real experiment data
SHA888 Aug 3, 2026
5a2080e
fix(export): address code review feedback on PR #124
SHA888 Aug 3, 2026
5671036
fix(export): sanitize dep paths, wrap data-access in try/except, add …
SHA888 Aug 3, 2026
2e7bd77
fix(export): address review feedback on PR #124
SHA888 Aug 3, 2026
c20b7fd
fix(export): sanitize variant_id and add encoding to write_text calls
SHA888 Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions TODO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@

### CLI Issues Found in Whole-Repo Code Review (2026-07-22)

- [ ] **`evoseal export` fabricates results instead of reporting real failures** _(exact file:line needs re-verification)_
- [x] **`evoseal export` fabricates results instead of reporting real failures** _(done 2026-08-03)_ — `export_results`, `export_variant`, and `export_all` now query `ExperimentDatabase` instead of returning hardcoded sample data; graceful error when no database or experiment found
- [ ] **Several `evoseal pipeline` subcommands are stubs**, not implemented behavior _(exact file:line needs re-verification)_

### SEAL Subsystem Issues Found in Whole-Repo Code Review (2026-07-22)
Expand Down Expand Up @@ -306,10 +306,10 @@
| Priority | Total | Done | Notes |
|----------|-------|------|-------|
| 🔴 P0 | 11 | 11 | Original 5 complete; all 6 critical bugs from 2026-07-22 whole-repo review fixed (PRs #74, #76-#79) |
| 🟠 P1 | 24 | 18 | Original safety/integration items done; +12 high-priority bugs from 2026-07-22 review (3 CI/CD pipeline fixes: workflow_run name mismatch, requirements/ path, security gate bypass); signal-handler init fix; safety.yaml created; monitoring dashboard auth+CORS fix |
| 🟠 P1 | 24 | 19 | Original safety/integration items done; +12 high-priority bugs from 2026-07-22 review (3 CI/CD pipeline fixes: workflow_run name mismatch, requirements/ path, security gate bypass); signal-handler init fix; safety.yaml created; monitoring dashboard auth+CORS fix; `evoseal export` now uses real data |
| 🟡 P2 | 30 | 25 | Co-evolution loop gaps (8 items, 8 done) + existing P2 + 13 medium bugs from 2026-07-22 review + 4 latent collect->train bugs found closing the loop (1 fixed, 1 new HF-format gap resolved); provider_manager health-check await fix; workflow-agent private-API/event-loop fix; checkpoint save/restore test; trust_remote_code security fix; safety-decision orchestration tests; structured improvement units |
| 🟢 P3 | 24 | 19 | Makefile, pre-commit, Docker, ADRs, ADR refresh, CHANGELOG complete; +11 hygiene items from 2026-07-22 review; Ollama provider retry/backoff fix; local_models TTL cache; workspace prompt file conventions; how-it-works tutorial; model_fine_tuner key validation; model_fine_tuner GPU availability check |
| **Total** | **89** | **73** | |
| **Total** | **89** | **74** | |

> Update this table as you complete items. Recommended flow: P0 → P1 → P2 → P3.
>
Expand Down
Loading
Loading