-
Notifications
You must be signed in to change notification settings - Fork 24
remove spectra_utils #616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
remove spectra_utils #616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the ingest_spectra
test suite, fully deleting tests/test_spectra_utils.py
.
- Deletes all tests validating the
ingest_spectrum
utility - Cleans up test artifacts related to spectra ingestion
Comments suppressed due to low confidence (1)
tests/test_spectra_utils.py:1
- [nitpick] Removing the entire
ingest_spectrum
test file will eliminate coverage for that functionality. Ensure the associated code is also removed or refactored and update CI/test configs accordingly to prevent coverage failures.
# temp_db and logger is defined in conftest.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes all ingest_spectra scripts and their associated tests while updating the database schema to enforce non-null constraints and adjust unique constraints for the spectra data.
- Removed tests for ingest_spectra functionality.
- Updated simple/schema.yaml by setting "nullable: false" for the instrument mode and adding mode to the unique constraint columns.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
tests/test_spectra_utils.py | Removed tests for ingest_spectrum functions, consistent with the removal of spectra_utils. |
simple/schema.yaml | Updated the schema: set mode as non-null and added it to a composite constraint. |
Comments suppressed due to low confidence (1)
simple/schema.yaml:1042
- Ensure that existing data complies with the new non-null constraint for the instrument mode column or that a migration strategy is provided to update existing null values.
+ nullable: false
@@ -1072,6 +1073,7 @@ tables: | |||
columns: | |||
- "#Spectra.source" | |||
- "#Spectra.regime" | |||
- "#Spectra.mode" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify that including '#Spectra.mode' in the composite unique constraint aligns with the intended data integrity rules and doesn't unintentionally restrict valid spectra entries.
Copilot uses AI. Check for mistakes.
Removes all of the ingest_spectra scripts.